Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 2840803002: Expose TryCatch is_verbose_ (Closed)

Created:
3 years, 7 months ago by danbev
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Expose TryCatch is_verbose_ This commit adds a getter for the private is_verbose_ member. The use case for this comes from Node.js where the ability to avoid calling FatalException if the TryCatch is verbose would be nice to have. BUG= Review-Url: https://codereview.chromium.org/2840803002 Cr-Commit-Position: refs/heads/master@{#45018} Committed: https://chromium.googlesource.com/v8/v8/+/f5fad6d9b85d31fd5d05b5c86bf2f2162391c589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M include/v8.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
danbev
Would you be able to review this when you get a chance? Thanks
3 years, 7 months ago (2017-04-25 05:48:54 UTC) #2
danno
adding additional reviewers...
3 years, 7 months ago (2017-04-25 07:26:39 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-04-25 14:44:46 UTC) #5
Michael Starzinger
LGTM.
3 years, 7 months ago (2017-04-25 15:30:50 UTC) #6
danbev
On 2017/04/25 15:30:50, Michael Starzinger wrote: > LGTM. Thanks for the reviews! Would it be ...
3 years, 7 months ago (2017-04-27 11:15:31 UTC) #7
jochen (gone - plz use gerrit)
no, please go ahead and commit
3 years, 7 months ago (2017-05-02 09:19:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840803002/1
3 years, 7 months ago (2017-05-02 09:57:33 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 10:28:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f5fad6d9b85d31fd5d05b5c86bf2f216239...

Powered by Google App Engine
This is Rietveld 408576698