views: Button ripple/highlight is visible during shelf swipe.

views: Button ripple/highlight is visible during shelf swipe.

More details in the bug.

TEST=manual
BUG=714265
Review-Url: https://codereview.chromium.org/2840773003
Cr-Commit-Position: refs/heads/master@{#468501}
Committed: https://chromium.googlesource.com/chromium/src/+/8c6e6113a0f57941108e5267f699bd7dd740828b

[sammiequon, 2017-04-25 18:18:10]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 18:18:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 19:25:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 19:25:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sammiequon, 2017-04-25 21:26:07]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 21:26:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 21:38:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:38:58]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sammiequon, 2017-04-26 23:15:11]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 23:15:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 00:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 00:33:32]

Dry run: This issue passed the CQ dry run.

[sammiequon, 2017-04-27 00:47:32]

Description was changed from

==========
views: Button ripple/highlight is visible during shelf swipe.

More details in the bug.

TEST=manual
BUG=714265
==========

to

==========
views: Button ripple/highlight is visible during shelf swipe.

More details in the bug.

TEST=manual
BUG=714265
==========

[sammiequon, 2017-04-27 00:47:33]

sammiequon@chromium.org changed reviewers:
+ bruthig@chromium.org

[sammiequon, 2017-04-27 00:47:50]

bruthig@ - Please take a look. Thanks!

[bruthig, 2017-04-27 13:58:46]

https://codereview.chromium.org/2840773003/diff/40001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_host_view.cc (right):

https://codereview.chromium.org/2840773003/diff/40001/ui/views/animation/ink_...
ui/views/animation/ink_drop_host_view.cc:78: case ui::ET_GESTURE_TAP_CANCEL:
Do you know if a TAP_CANCEL happen whenever a SCROLL_BEGIN happens?

https://codereview.chromium.org/2840773003/diff/40001/ui/views/animation/ink_...
ui/views/animation/ink_drop_host_view.cc:88: (current_ink_drop_state ==
InkDropState::ACTION_TRIGGERED ||
Can you add a clause here so that we don't initiate a HIDDEN animation if the
|current_ink_drop_state| is already HIDDEN? You will have to update some tests,
including reverting the test changes you already made.

[sammiequon, 2017-04-27 16:54:24]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 16:55:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 17:25:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 17:25:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sammiequon, 2017-04-27 18:43:46]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 18:44:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 19:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:52:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sammiequon, 2017-04-27 20:45:22]

Patchset #5 (id:80001) has been deleted

[sammiequon, 2017-04-27 20:45:26]

Patchset #4 (id:60001) has been deleted

[sammiequon, 2017-04-27 20:50:34]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 20:50:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 21:13:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 21:13:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sammiequon, 2017-04-27 22:41:19]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 22:42:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:37:23]

Dry run: This issue passed the CQ dry run.

[sammiequon, 2017-04-28 04:58:03]

https://codereview.chromium.org/2840773003/diff/40001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_host_view.cc (right):

https://codereview.chromium.org/2840773003/diff/40001/ui/views/animation/ink_...
ui/views/animation/ink_drop_host_view.cc:78: case ui::ET_GESTURE_TAP_CANCEL:
On 2017/04/27 13:58:46, bruthig wrote:
> Do you know if a TAP_CANCEL happen whenever a SCROLL_BEGIN happens?

Oops, I did not mean to remove the SCROLL_BEGIN here.

https://codereview.chromium.org/2840773003/diff/40001/ui/views/animation/ink_...
ui/views/animation/ink_drop_host_view.cc:88: (current_ink_drop_state ==
InkDropState::ACTION_TRIGGERED ||
On 2017/04/27 13:58:46, bruthig wrote:
> Can you add a clause here so that we don't initiate a HIDDEN animation if the
> |current_ink_drop_state| is already HIDDEN? You will have to update some
tests,
> including reverting the test changes you already made.

Done.

[bruthig, 2017-05-01 15:43:49]

lgtm

[sammiequon, 2017-05-01 16:59:50]

On 2017/05/01 15:43:49, bruthig wrote:
> lgtm

Thanks!

[sammiequon, 2017-05-01 17:00:30]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-05-01 17:01:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 17:10:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 17:10:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sammiequon, 2017-05-01 17:13:03]

sammiequon@chromium.org changed reviewers:
+ msw@chromium.org

[sammiequon, 2017-05-01 17:13:42]

On 2017/05/01 17:10:03, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

msw@ - Please take a look at ash/shelf/*. Thanks!

[msw, 2017-05-01 22:03:45]

rubber stamp lgtm

[sammiequon, 2017-05-02 00:05:47]

On 2017/05/01 22:03:45, msw wrote:
> rubber stamp lgtm

Thanks!

[sammiequon, 2017-05-02 00:05:53]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-05-02 00:06:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 00:13:08]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493683553025980,
"parent_rev": "1b455e60d47dab9b1c50e6f68cef59c0751103e0", "commit_rev":
"8c6e6113a0f57941108e5267f699bd7dd740828b"}

[commit-bot: I haz the power, 2017-05-02 00:13:16]

Description was changed from

==========
views: Button ripple/highlight is visible during shelf swipe.

More details in the bug.

TEST=manual
BUG=714265
==========

to

==========
views: Button ripple/highlight is visible during shelf swipe.

More details in the bug.

TEST=manual
BUG=714265

Review-Url: https://codereview.chromium.org/2840773003
Cr-Commit-Position: refs/heads/master@{#468501}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c6e6113a0f57941108e5267f699...
==========

[commit-bot: I haz the power, 2017-05-02 00:13:17]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8c6e6113a0f57941108e5267f699...