Issue 2840763002: Enable MacOSX native notifications by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2840763002: Enable MacOSX native notifications by default (Closed)

Created:
3 years, 8 months ago by Miguel Garcia

Modified:
3 years, 8 months ago

Reviewers:
Finnur

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Enable MacOSX native notifications by default TBR=finnur BUG=714665 Review-Url: https://codereview.chromium.org/2833993002 Cr-Commit-Position: refs/heads/master@{#466687} (cherry picked from commit 9b50286f24130476571e2d8e2a5a410e20f9f787) Review-Url: https://codereview.chromium.org/2840763002 . Cr-Commit-Position: refs/branch-heads/3071@{#181} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1ed8de2cf4ca8f1c0597376ad57cf7f3a5616b8d

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -0 lines)			Patch
M	chrome/browser/extensions/service_worker_apitest.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/notification_interactive_uitest_support.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/notification_interactive_uitest_support.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/platform_notification_service_unittest.cc	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_features.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Miguel Garcia

3 years, 8 months ago (2017-04-24 22:25:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1ed8de2cf4ca8f1c0597376ad57cf7f3a5616b8d.