Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2840753003: [LayoutNG] Add 2nd flaky results to FlagExpectations for LayoutNG (Closed)

Created:
2 years, 6 months ago by kojii
Modified:
2 years, 6 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add 2nd flaky results to FlagExpectations for LayoutNG This patch adds another flaky results from 5-6 iterations of running tests. I will run a few more iterations and see how it stabilizes. BUG=591099 Review-Url: https://codereview.chromium.org/2840753003 Cr-Commit-Position: refs/heads/master@{#467256} Committed: https://chromium.googlesource.com/chromium/src/+/61b8dd80224f465e251452cf9ca08bea8cf9d28e

Patch Set 1 #

Patch Set 2 : More iterations #

Patch Set 3 : More iterations #

Patch Set 4 : More iterations #

Patch Set 5 : More iterations #

Patch Set 6 : Add unexpected passes from bot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1493 lines, -1268 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 3 4 5 371 chunks +1493 lines, -1268 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
kojii
PTAL, another 5-6 iterations. It looks like # of changes/additions is decreasing.
2 years, 6 months ago (2017-04-25 18:35:16 UTC) #5
kojii
Finally linux_layout_tests_layout_ng bot passed for the first time! https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_layout_ng/builds/102 (...though 881 flaky tests are not ...
2 years, 6 months ago (2017-04-26 06:42:14 UTC) #12
eae
LGTM Feeel free to TBR these
2 years, 6 months ago (2017-04-26 06:50:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840753003/100001
2 years, 6 months ago (2017-04-26 06:51:02 UTC) #15
commit-bot: I haz the power
2 years, 6 months ago (2017-04-26 06:54:56 UTC) #18
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/61b8dd80224f465e251452cf9ca0...

Powered by Google App Engine
This is Rietveld 408576698