Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2840733002: [Merge to 3071] Use faster, but less information methods to calculate memory dumps on macOS. (Closed)

Created:
3 years, 8 months ago by erikchen
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to 3071] Use faster, but less information methods to calculate memory dumps on macOS. > Switch to use mach_vm_region(TOP_INFO) and mach_vm_region(BASIC_INFO) instead of > mach_vm_region_recurse(). While the latter provides more information, both on > submaps and on swapped/clean pages, it's two order of magnitudes slower. > Attempting to take a memory dump with ~50 renderer renderers my machine unusable > for over a minute. BUG=713481 Review-Url: https://codereview.chromium.org/2826123004 Cr-Commit-Position: refs/heads/master@{#466417} (cherry picked from commit 12531f29074985a71e18f60a2e8ea79b4f24314c) Review-Url: https://codereview.chromium.org/2840733002 . Cr-Commit-Position: refs/branch-heads/3071@{#177} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/8f0910deb4cac181efa7976efca1a3811dcbe93d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -98 lines) Patch
M base/process/process_metrics.h View 2 chunks +40 lines, -0 lines 0 comments Download
M base/process/process_metrics_mac.cc View 4 chunks +56 lines, -57 lines 0 comments Download
M components/tracing/common/process_metrics_memory_dump_provider.cc View 4 chunks +33 lines, -41 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
erikchen
3 years, 8 months ago (2017-04-24 21:06:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f0910deb4cac181efa7976efca1a3811dcbe93d.

Powered by Google App Engine
This is Rietveld 408576698