Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2840723003: build: Enable function sections and data sections during LTO. (Closed)

Created:
3 years, 7 months ago by pcc1
Modified:
3 years, 7 months ago
Reviewers:
krasin1, Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Enable function sections and data sections during LTO. This allows the linker to apply --gc-sections to object files created during LTO. This yields a >8MB reduction in stripped binary size for official binaries built with ThinLTO. This change increases the size of an official binary built with regular LTO by 8192 bytes, but this probably isn't worth worrying about. BUG=660216, 607968 R=thakis@chromium.org,krasin@chromium.org Review-Url: https://codereview.chromium.org/2840723003 Cr-Commit-Position: refs/heads/master@{#467129} Committed: https://chromium.googlesource.com/chromium/src/+/deda22b114bc8308ad1ae888727a66ceda9189aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +15 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pcc1
3 years, 7 months ago (2017-04-25 20:11:21 UTC) #1
Nico
lgtm
3 years, 7 months ago (2017-04-25 20:14:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840723003/1
3 years, 7 months ago (2017-04-25 20:17:13 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 21:54:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/deda22b114bc8308ad1ae888727a...

Powered by Google App Engine
This is Rietveld 408576698