Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2840693002:
Use TaskScheduler instead of blocking pool in io_thread.cc. (Closed)
DescriptionUse TaskScheduler instead of blocking pool in io_thread.cc.
The blocking pool is being deprecated in favor of TaskScheduler.
BUG=667892
R=cbentzel@chromium.org
Review-Url: https://codereview.chromium.org/2840693002
Cr-Commit-Position: refs/heads/master@{#467466}
Committed: https://chromium.googlesource.com/chromium/src/+/dd7eb407434e63553da0cd20ec865272a562ba3c
Patch Set 1 #
Total comments: 2
Patch Set 2 : USER_VISIBLE #Messages
Total messages: 18 (11 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used to post tasks. https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, please lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks! - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the task priority is not set explicitly (no .WithTaskPriority())? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority). What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior())? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2840693002/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/2840693002/diff/1/chrome/browser/io_thread.cc... chrome/browser/io_thread.cc:1086: .WithPriority(base::TaskPriority::BACKGROUND) This will be used for loading file:// URLs which may have some user visible impact. Should this be USER_VISIBLE instead?
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please take another look https://codereview.chromium.org/2840693002/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/2840693002/diff/1/chrome/browser/io_thread.cc... chrome/browser/io_thread.cc:1086: .WithPriority(base::TaskPriority::BACKGROUND) On 2017/04/25 05:52:26, cbentzel wrote: > This will be used for loading file:// URLs which may have some user visible > impact. Should this be USER_VISIBLE instead? Done.
On 2017/04/26 19:40:42, fdoray wrote: > Please take another look > > https://codereview.chromium.org/2840693002/diff/1/chrome/browser/io_thread.cc > File chrome/browser/io_thread.cc (right): > > https://codereview.chromium.org/2840693002/diff/1/chrome/browser/io_thread.cc... > chrome/browser/io_thread.cc:1086: .WithPriority(base::TaskPriority::BACKGROUND) > On 2017/04/25 05:52:26, cbentzel wrote: > > This will be used for loading file:// URLs which may have some user visible > > impact. Should this be USER_VISIBLE instead? > > Done. LGTM
The CQ bit was checked by cbentzel@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493241822210360,
"parent_rev": "0bca4733a6174477714e64a9a453f4f8abdfe9f0", "commit_rev":
"dd7eb407434e63553da0cd20ec865272a562ba3c"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in io_thread.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=cbentzel@chromium.org ========== to ========== Use TaskScheduler instead of blocking pool in io_thread.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=cbentzel@chromium.org Review-Url: https://codereview.chromium.org/2840693002 Cr-Commit-Position: refs/heads/master@{#467466} Committed: https://chromium.googlesource.com/chromium/src/+/dd7eb407434e63553da0cd20ec86... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/dd7eb407434e63553da0cd20ec86... |
