Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2840673002: Opening links clicked from the answer card in a new tab. (Closed)

Created:
3 years, 8 months ago by vadimt
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Opening links clicked from the answer card in a new tab. Bug=712331 Review-Url: https://codereview.chromium.org/2840673002 Cr-Commit-Position: refs/heads/master@{#466755} Committed: https://chromium.googlesource.com/chromium/src/+/261a600988a948149611fe6292221d1fd3bdb446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
M chrome/browser/ui/app_list/search_answer_web_contents_delegate.h View 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc View 3 chunks +33 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
vadimt
3 years, 8 months ago (2017-04-24 19:20:46 UTC) #2
xiyuan
lgtm
3 years, 8 months ago (2017-04-24 20:21:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840673002/1
3 years, 8 months ago (2017-04-24 20:22:16 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 20:50:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/261a600988a948149611fe629222...

Powered by Google App Engine
This is Rietveld 408576698