Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2840633002: Remove test-only method QuicStreamFactory::CreateFromSession() (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove test-only method QuicStreamFactory::CreateFromSession() Review-Url: https://codereview.chromium.org/2840633002 Cr-Commit-Position: refs/heads/master@{#466885} Committed: https://chromium.googlesource.com/chromium/src/+/68a80ebd6df9dc550b301443b2db69a13b98ef8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -32 lines) Patch
M net/quic/chromium/quic_stream_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_peer.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_peer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 3 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ryan Hamilton
3 years, 8 months ago (2017-04-24 18:19:25 UTC) #2
Jana
lgtm
3 years, 8 months ago (2017-04-24 18:27:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840633002/1
3 years, 8 months ago (2017-04-25 00:21:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/411983)
3 years, 8 months ago (2017-04-25 01:19:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840633002/1
3 years, 8 months ago (2017-04-25 02:31:29 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 05:24:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68a80ebd6df9dc550b301443b2db...

Powered by Google App Engine
This is Rietveld 408576698