Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2840593003: Revert of Re-enable Cloud printers for ChromeOS kiosks. (Closed)

Created:
3 years, 8 months ago by pkalinnikov
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang, xdai1, skau
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable Cloud printers for ChromeOS kiosks. (patchset #3 id:40001 of https://codereview.chromium.org/2838603004/ ) Reason for revert: Seems causing the "Linux MSan Tests" bot fail on PrintPreviewDestinationSearchTest.Select test. Original issue's description: > Re-enable Cloud printers for ChromeOS kiosks. > > In a previous CL (https://codereview.chromium.org/2760753002) we made an > assumption that only local printers would appear in the local printer > list. This turns out to be incorrect. The actual condition is that only > cloud printers appear in the cloud list and sometimes appear in the local > list (when they're device printers). This CL accounts for this behavior > and adds a test so we don't break it in the future. > > BUG=713831 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2838603004 > Cr-Commit-Position: refs/heads/master@{#466895} > Committed: https://chromium.googlesource.com/chromium/src/+/e02af5b94d73c62ad0708593d4514aa15be4ee6d TBR=xdai@chromium.org,thestig@chromium.org,skau@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=713831 Review-Url: https://codereview.chromium.org/2840593003 Cr-Commit-Position: refs/heads/master@{#466983} Committed: https://chromium.googlesource.com/chromium/src/+/fafa2cae6c2ecc2c3668e2189db044fc2de1d349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -29 lines) Patch
M chrome/browser/resources/print_preview/search/destination_search.js View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/test/data/webui/print_preview_destination_search_test.js View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pkalinnikov
Created Revert of Re-enable Cloud printers for ChromeOS kiosks.
3 years, 8 months ago (2017-04-25 14:23:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840593003/1
3 years, 8 months ago (2017-04-25 14:24:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fafa2cae6c2ecc2c3668e2189db044fc2de1d349
3 years, 8 months ago (2017-04-25 14:24:36 UTC) #6
Lei Zhang
3 years, 8 months ago (2017-04-25 16:08:25 UTC) #7
Message was sent while issue was closed.
lgtm, but please include a link to the failing bot:
https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/bu...

Powered by Google App Engine
This is Rietveld 408576698