Implement SpdyMakeUnique and SpdyWrapUnique.

Implement SpdyMakeUnique and SpdyWrapUnique.

spdy/platform/*/spdy_ptr_util{,_impl}.h are almost verbatim copies of
quic/platform/*/quic_ptr_util{,_impl}.h.  Note "util" versus "utils" in
the filenames, despite some other headers are pluralized: this is for
consistency with //net/quic/platform/quic_ptr_util and
//base/memory/ptr_util.h.

(Also note that quic/platform/*/quic_ptr_util{,_impl}.h incorrectly uses
std::move in return, which potentially prevents return value
optimization, so I'm not doing it here.)

Also change most naked new's to SpdyMakeUnique, because clearly, naked
new is the devil itself.  And add #include <new> for most remaining new
(except for the ones that I plan to remove in the near future).

This CL lands server change 153775072 by bnc.

BUG=488484
Review-Url: https://codereview.chromium.org/2840563003
Cr-Commit-Position: refs/heads/master@{#467665}
Committed: https://chromium.googlesource.com/chromium/src/+/dae95a8d511966759752f89b3a822838e6292a6f

[Bence, 2017-04-25 01:44:12]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 01:44:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 03:25:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 03:25:35]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-04-25 09:57:55]

bnc@chromium.org changed reviewers:
+ birenroy@chromium.org

[Bence, 2017-04-25 09:57:56]

Biren: PTAL.  Thank you.

[Biren Roy, 2017-04-26 18:25:31]

lgtm

[Bence, 2017-04-26 19:03:53]

bnc@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Bence, 2017-04-26 19:03:53]

xunjieli: please rubber stamp.  Per your earlier request, a presubmit test is on
the way.

Biren: thank you for the review.

[xunjieli, 2017-04-26 21:10:56]

On 2017/04/26 19:03:53, Bence wrote:
> xunjieli: please rubber stamp.  Per your earlier request, a presubmit test is
on
> the way.
> 
> Biren: thank you for the review.

lgtm

[Bence, 2017-04-26 23:07:59]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2017-04-26 23:08:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 02:59:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 02:59:28]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bence, 2017-04-27 13:57:19]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2017-04-27 13:57:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 14:05:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493301439467710, "parent_rev":
"34bf6052665ebb01cfd3dba05e2e72a64e08da67", "commit_rev":
"dae95a8d511966759752f89b3a822838e6292a6f"}

[commit-bot: I haz the power, 2017-04-27 14:05:26]

Description was changed from

==========
Implement SpdyMakeUnique and SpdyWrapUnique.

spdy/platform/*/spdy_ptr_util{,_impl}.h are almost verbatim copies of
quic/platform/*/quic_ptr_util{,_impl}.h.  Note "util" versus "utils" in
the filenames, despite some other headers are pluralized: this is for
consistency with //net/quic/platform/quic_ptr_util and
//base/memory/ptr_util.h.

(Also note that quic/platform/*/quic_ptr_util{,_impl}.h incorrectly uses
std::move in return, which potentially prevents return value
optimization, so I'm not doing it here.)

Also change most naked new's to SpdyMakeUnique, because clearly, naked
new is the devil itself.  And add #include <new> for most remaining new
(except for the ones that I plan to remove in the near future).

This CL lands server change 153775072 by bnc.

BUG=488484
==========

to

==========
Implement SpdyMakeUnique and SpdyWrapUnique.

spdy/platform/*/spdy_ptr_util{,_impl}.h are almost verbatim copies of
quic/platform/*/quic_ptr_util{,_impl}.h.  Note "util" versus "utils" in
the filenames, despite some other headers are pluralized: this is for
consistency with //net/quic/platform/quic_ptr_util and
//base/memory/ptr_util.h.

(Also note that quic/platform/*/quic_ptr_util{,_impl}.h incorrectly uses
std::move in return, which potentially prevents return value
optimization, so I'm not doing it here.)

Also change most naked new's to SpdyMakeUnique, because clearly, naked
new is the devil itself.  And add #include <new> for most remaining new
(except for the ones that I plan to remove in the near future).

This CL lands server change 153775072 by bnc.

BUG=488484

Review-Url: https://codereview.chromium.org/2840563003
Cr-Commit-Position: refs/heads/master@{#467665}
Committed:
https://chromium.googlesource.com/chromium/src/+/dae95a8d511966759752f89b3a82...
==========

[commit-bot: I haz the power, 2017-04-27 14:05:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dae95a8d511966759752f89b3a82...