Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issue 2840563002: bindings: Remove unused To*Array() and ToV8Sequence() functions. (Closed)

Created:
3 years, 8 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 8 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Remove unused To*Array() and ToV8Sequence() functions. With all callers converted to NativeValueTraits<IDLSequence<T>>::NativeValue(), which implements the most recent WebIDL JS->Sequence conversion steps (including custom iterators), we can remove several unused functions and deprecated NativeValueTraits specializations. Of all the To*Array() functions left, only ToImplArray(Vector<ScriptValue>) was not removed, as it still serves a purpose and will just be renamed in the future. V8BindingTest was accordingly adjust to only test that one function. BUG=690428, 713200 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2840563002 Cr-Commit-Position: refs/heads/master@{#466940} Committed: https://chromium.googlesource.com/chromium/src/+/345e0fb9fe291f6d32d47365f5767099ccf87d30

Patch Set 1 #

Patch Set 2 : Rebase after #466709 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -384 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.h View 1 4 chunks +0 lines, -243 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingTest.cpp View 1 3 chunks +12 lines, -128 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Raphael Kubo da Costa (rakuco)
PTAL
3 years, 8 months ago (2017-04-24 13:57:06 UTC) #1
haraken
LGTM!
3 years, 8 months ago (2017-04-24 14:06:51 UTC) #4
bashi
lgtm Thanks for the work!
3 years, 8 months ago (2017-04-24 23:20:59 UTC) #7
Yuki
LGTM.
3 years, 8 months ago (2017-04-25 07:54:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840563002/1
3 years, 8 months ago (2017-04-25 07:54:40 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/419518)
3 years, 8 months ago (2017-04-25 07:59:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840563002/20001
3 years, 8 months ago (2017-04-25 08:51:13 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 10:32:19 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/345e0fb9fe291f6d32d47365f576...

Powered by Google App Engine
This is Rietveld 408576698