[d8] implement console for d8.

[d8] implement console for d8.

for now, it's just the methods
- log
- warn
- debug
- info
- error
- time
- timeEnd

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2840543002
Cr-Commit-Position: refs/heads/master@{#44797}
Committed: https://chromium.googlesource.com/v8/v8/+/461e47a8fee3624f7fda3a5b52ae760f8302d7c3

[rongjie, 2017-04-24 11:35:56]

loorongjie@gmail.com changed reviewers:
+ loorongjie@gmail.com

[rongjie, 2017-04-24 11:35:56]

https://codereview.chromium.org/2840543002/diff/1/src/d8-console.cc
File src/d8-console.cc (right):

https://codereview.chromium.org/2840543002/diff/1/src/d8-console.cc#newcode14
src/d8-console.cc:14: static const char* kConsoleColorReset = "\x1b[0m";
Note that Windows does not support ANSI color, they will be printed as weird
characters.

You can use Win32 API (SetConsoleTextAttribute) for console color, I can send a
CL later if you want.

[Jarin, 2017-04-24 11:41:55]

lgtm, thanks!

[Yang, 2017-04-24 11:43:54]

On 2017/04/24 11:35:56, rongjie wrote:
> https://codereview.chromium.org/2840543002/diff/1/src/d8-console.cc
> File src/d8-console.cc (right):
> 
> https://codereview.chromium.org/2840543002/diff/1/src/d8-console.cc#newcode14
> src/d8-console.cc:14: static const char* kConsoleColorReset = "\x1b[0m";
> Note that Windows does not support ANSI color, they will be printed as weird
> characters.
> 
> You can use Win32 API (SetConsoleTextAttribute) for console color, I can send
a
> CL later if you want.

Thanks for the hint. I don't care enough about colors to fix that. So I'm
removing that part.

[Yang, 2017-04-24 11:43:58]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 11:44:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 12:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 12:05:29]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Yang, 2017-04-24 12:55:56]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-04-24 12:55:57]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2840543002/#ps40001
(title: "no stress")

[commit-bot: I haz the power, 2017-04-24 12:56:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 13:23:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493038556702890,
"parent_rev": "6a833f23af8d27d8ccca1ddbb0c1ff6619d969ef", "commit_rev":
"461e47a8fee3624f7fda3a5b52ae760f8302d7c3"}

[commit-bot: I haz the power, 2017-04-24 13:23:16]

Description was changed from

==========
[d8] implement console for d8.

for now, it's just the methods
- log
- warn
- debug
- info
- error
- time
- timeEnd

R=jarin@chromium.org
==========

to

==========
[d8] implement console for d8.

for now, it's just the methods
- log
- warn
- debug
- info
- error
- time
- timeEnd

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2840543002
Cr-Commit-Position: refs/heads/master@{#44797}
Committed:
https://chromium.googlesource.com/v8/v8/+/461e47a8fee3624f7fda3a5b52ae760f830...
==========

[commit-bot: I haz the power, 2017-04-24 13:23:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/461e47a8fee3624f7fda3a5b52ae760f830...