Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2840533003: [android] Make main_dex_list.py use the same proguard as everything else. (Closed)

Created:
3 years, 8 months ago by jbudorick
Modified:
3 years, 8 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Make main_dex_list.py use the same proguard as everything else. Realized that main_dex_list was using a different version of proguard while working on test multidex. Review-Url: https://codereview.chromium.org/2840533003 Cr-Commit-Position: refs/heads/master@{#466733} Committed: https://chromium.googlesource.com/chromium/src/+/55fc2829afb24aa310dde477d64d07d35a32e46e

Patch Set 1 #

Patch Set 2 : remove unused constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M build/android/gyp/main_dex_list.py View 2 chunks +4 lines, -1 line 0 comments Download
M build/android/pylib/constants/__init__.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/android/internal_rules.gni View 4 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jbudorick
3 years, 8 months ago (2017-04-24 17:54:52 UTC) #2
agrieve
On 2017/04/24 17:54:52, jbudorick wrote: lgtm
3 years, 8 months ago (2017-04-24 18:38:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840533003/20001
3 years, 8 months ago (2017-04-24 18:57:31 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 20:21:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/55fc2829afb24aa310dde477d64d...

Powered by Google App Engine
This is Rietveld 408576698