Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2840483002:
Log the creation of Sign In related dialog boxes. (Closed)
|
Created:
3 years, 8 months ago by pdyson Modified:
3 years, 7 months ago CC:
asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, estade+watch_chromium.org, extensions-reviews_chromium.org, mathp+autofillwatch_chromium.org, rogerm+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, tfarina, vabr+watchlistautofill_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionLog the creation of Sign In related dialog boxes.
BUG=705331
Review-Url: https://codereview.chromium.org/2840483002
Cr-Commit-Position: refs/heads/master@{#469264}
Committed: https://chromium.googlesource.com/chromium/src/+/918928e65b775182d50ea33ac24d45e9501e7e82
Patch Set 1 #Patch Set 2 : Removed files submitted in another cl. #Patch Set 3 : Updated after feedback from Sign In team. #Patch Set 4 : Add Sign In Email Confirmation. #
Total comments: 1
Patch Set 5 : change enum to SIGN_IN #Patch Set 6 : All enums moved to separate file by another cl, need to sync. #Patch Set 7 : correct enums in enums.xml #
Messages
Total messages: 41 (28 generated)
The CQ bit was checked by pdyson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
pdyson@chromium.org changed reviewers: + jwd@chromium.org, msarda@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
msarda@, can you take a look at this?
metrics LGTM
LGTM with a enum entry change. https://codereview.chromium.org/2840483002/diff/60001/chrome/browser/ui/brows... File chrome/browser/ui/browser_dialogs.h (right): https://codereview.chromium.org/2840483002/diff/60001/chrome/browser/ui/brows... chrome/browser/ui/browser_dialogs.h:236: SIGN_IN_EXISTING_DATA = 27, This is the regular sign-in screen, so just name this SIGN_IN
On 2017/05/02 at 09:55:03, msarda wrote: > LGTM with a enum entry change. > > https://codereview.chromium.org/2840483002/diff/60001/chrome/browser/ui/brows... > File chrome/browser/ui/browser_dialogs.h (right): > > https://codereview.chromium.org/2840483002/diff/60001/chrome/browser/ui/brows... > chrome/browser/ui/browser_dialogs.h:236: SIGN_IN_EXISTING_DATA = 27, > This is the regular sign-in screen, so just name this SIGN_IN I've made this change.
pdyson@chromium.org changed reviewers: + msw@chromium.org
msw@ can you take a look at this? I've already got approval from msarda@ who is on the Signin team.
lgtm
The CQ bit was checked by pdyson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by pdyson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org, msarda@chromium.org Link to the patchset: https://codereview.chromium.org/2840483002/#ps80001 (title: "change enum to SIGN_IN")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for tools/metrics/histograms/histograms.xml: While running git apply --index -3 -p1; error: patch failed: tools/metrics/histograms/histograms.xml:90190 Falling back to three-way merge... Applied patch to 'tools/metrics/histograms/histograms.xml' with conflicts. U tools/metrics/histograms/histograms.xml Patch: tools/metrics/histograms/histograms.xml Index: tools/metrics/histograms/histograms.xml diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index d2b0e4e5aff9046ab814cf657eb452ef554eaf2f..bc65e944870f955f6bbd619f292e09cf4efa39cf 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -90190,6 +90190,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. <int value="24" label="Payment Request"/> <int value="25" label="Save Card"/> <int value="26" label="Card Unmask"/> + <int value="27" label="Sign In"/> + <int value="28" label="Sign In Sync Confirmation"/> + <int value="29" label="Sign In Error"/> + <int value="30" label="Sign In Email Confirmation"/> + <int value="31" label="Profile Chooser"/> </enum> <enum name="DidNavigateToAd" type="int">
The CQ bit was checked by pdyson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by pdyson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org, jwd@chromium.org, msarda@chromium.org Link to the patchset: https://codereview.chromium.org/2840483002/#ps100001 (title: "All enums moved to separate file by another cl, need to sync.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by pdyson@chromium.org
The CQ bit was checked by pdyson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by pdyson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org, jwd@chromium.org, msarda@chromium.org Link to the patchset: https://codereview.chromium.org/2840483002/#ps120001 (title: "correct enums in enums.xml")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1493869459883920,
"parent_rev": "880198880c77eff69100e7ec9e8f75518257397d", "commit_rev":
"918928e65b775182d50ea33ac24d45e9501e7e82"}
Message was sent while issue was closed.
Description was changed from ========== Log the creation of Sign In related dialog boxes. BUG=705331 ========== to ========== Log the creation of Sign In related dialog boxes. BUG=705331 Review-Url: https://codereview.chromium.org/2840483002 Cr-Commit-Position: refs/heads/master@{#469264} Committed: https://chromium.googlesource.com/chromium/src/+/918928e65b775182d50ea33ac24d... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/918928e65b775182d50ea33ac24d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
