chromeos: converts TopLevelWindowFactoryTest to AshTestBase

chromeos: converts TopLevelWindowFactoryTest to AshTestBase

This makes AshTestBase::CreateTestWindow() get the logic (when in
mash) that is in
WmTestHelper::CreateTestWindow(). I added
AshTestBase::CreateTestWindow() for migration from AshTest/WmTestBase
to AshTestBase.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2840393002
Cr-Commit-Position: refs/heads/master@{#467566}
Committed: https://chromium.googlesource.com/chromium/src/+/6e5be9d31acb3b07114e88cc3d24c59e18f47be0

[sky, 2017-04-26 22:58:07]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 22:58:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 23:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 23:04:18]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[James Cook, 2017-04-26 23:54:08]

LGTM

https://codereview.chromium.org/2840393002/diff/1/ash/mus/top_level_window_fa...
File ash/mus/top_level_window_factory_unittest.cc (right):

https://codereview.chromium.org/2840393002/diff/1/ash/mus/top_level_window_fa...
ash/mus/top_level_window_factory_unittest.cc:96: const gfx::Rect bounds(1, 2,
124, 345);
Hooray for mixed data in tests!

[sky, 2017-04-27 00:01:07]

The CQ bit was checked by sky@chromium.org

[sky, 2017-04-27 00:01:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2840393002/#ps20001
(title: "merge")

[commit-bot: I haz the power, 2017-04-27 00:01:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 00:36:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 00:36:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-04-27 02:52:21]

The CQ bit was checked by sky@chromium.org

[sky, 2017-04-27 02:52:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2840393002/#ps40001
(title: "remove duplicate function")

[commit-bot: I haz the power, 2017-04-27 02:53:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 03:24:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493261541605540,
"parent_rev": "7e9153cd910b54445c6d4717fe49596c13ec57ab", "commit_rev":
"6e5be9d31acb3b07114e88cc3d24c59e18f47be0"}

[commit-bot: I haz the power, 2017-04-27 03:25:36]

Description was changed from

==========
chromeos: converts TopLevelWindowFactoryTest to AshTestBase

This makes AshTestBase::CreateTestWindow() get the logic (when in
mash) that is in
WmTestHelper::CreateTestWindow(). I added
AshTestBase::CreateTestWindow() for migration from AshTest/WmTestBase
to AshTestBase.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org
==========

to

==========
chromeos: converts TopLevelWindowFactoryTest to AshTestBase

This makes AshTestBase::CreateTestWindow() get the logic (when in
mash) that is in
WmTestHelper::CreateTestWindow(). I added
AshTestBase::CreateTestWindow() for migration from AshTest/WmTestBase
to AshTestBase.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2840393002
Cr-Commit-Position: refs/heads/master@{#467566}
Committed:
https://chromium.googlesource.com/chromium/src/+/6e5be9d31acb3b07114e88cc3d24...
==========

[commit-bot: I haz the power, 2017-04-27 03:25:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6e5be9d31acb3b07114e88cc3d24...