Add encounteredError() to AssociatedInterfacePtrController.

Add encounteredError() to AssociatedInterfacePtrController.

Indicates whether an error has been encountered by the interface endpoint client. If true, method calls made on this interface will be dropped (and may already have been dropped).

BUG=695635
Review-Url: https://codereview.chromium.org/2840333002
Cr-Commit-Position: refs/heads/master@{#467869}
Committed: https://chromium.googlesource.com/chromium/src/+/2e7fbc6d817dc0307b5e64992590114b10566f7e

[wangjimmy, 2017-04-26 21:30:50]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 21:31:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wangjimmy, 2017-04-26 21:31:41]

wangjimmy@chromium.org changed reviewers:
+ rockot@chromium.org

[wangjimmy, 2017-04-26 21:31:41]

Hi Ken, PTAL

[commit-bot: I haz the power, 2017-04-26 23:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 23:46:44]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-04-27 15:03:27]

https://codereview.chromium.org/2840333002/diff/1/mojo/public/js/lib/interfac...
File mojo/public/js/lib/interface_endpoint_client.js (right):

https://codereview.chromium.org/2840333002/diff/1/mojo/public/js/lib/interfac...
mojo/public/js/lib/interface_endpoint_client.js:30: this.encounteredError =
false;
I would prefer that we keep this value "private".

You could either add an encounteredError() function to access it, or add a
public getter property:

var getProperty = function(client) { return client.encounteredError_; };
Object.defineProperty(this, "encounteredError", getProperty.bind(this));

which would then be accessible like any other object property (i.e.,
fooClient.encounteredError), but read-only.

[Ken Rockot(use gerrit already), 2017-04-27 15:04:03]

On 2017/04/27 at 15:03:27, Ken Rockot wrote:
>
https://codereview.chromium.org/2840333002/diff/1/mojo/public/js/lib/interfac...
> File mojo/public/js/lib/interface_endpoint_client.js (right):
> 
>
https://codereview.chromium.org/2840333002/diff/1/mojo/public/js/lib/interfac...
> mojo/public/js/lib/interface_endpoint_client.js:30: this.encounteredError =
false;
> I would prefer that we keep this value "private".
> 
> You could either add an encounteredError() function to access it, or add a
public getter property:
> 
> var getProperty = function(client) { return client.encounteredError_; };

Err, I guess something like getEncounteredError would be a better name for the
local variable

> Object.defineProperty(this, "encounteredError", getProperty.bind(this));
> 
> which would then be accessible like any other object property (i.e.,
fooClient.encounteredError), but read-only.

[wangjimmy, 2017-04-28 01:59:07]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 02:00:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wangjimmy, 2017-04-28 02:02:29]

On 2017/04/27 15:04:03, Ken Rockot wrote:
> On 2017/04/27 at 15:03:27, Ken Rockot wrote:
> > Object.defineProperty(this, "encounteredError", getProperty.bind(this));
> > 
> > which would then be accessible like any other object property (i.e.,
> fooClient.encounteredError), but read-only.


I made encounteredError private and added a method getEncounteredError() it.
I decided not to use Object.defineProperty, interferes with the clojure
compiler's property renaming

https://google.github.io/styleguide/jsguide.html#features-classes-getters-and...
"Do not use Object.defineProperty, which interferes with property renaming."

[Ken Rockot(use gerrit already), 2017-04-28 02:50:21]

lgtm

[commit-bot: I haz the power, 2017-04-28 03:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:04:19]

Dry run: This issue passed the CQ dry run.

[wangjimmy, 2017-04-28 03:18:23]

The CQ bit was checked by wangjimmy@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:19:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 03:25:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493349503317200,
"parent_rev": "201eaf7de7e46e23f5955dc8b57db0d76add14c2", "commit_rev":
"2e7fbc6d817dc0307b5e64992590114b10566f7e"}

[commit-bot: I haz the power, 2017-04-28 03:25:49]

Description was changed from

==========
Add encounteredError() to AssociatedInterfacePtrController.

Indicates whether an error has been encountered by the interface endpoint
client. If true, method calls made on this interface will be dropped (and may
already have been dropped).

BUG=695635
==========

to

==========
Add encounteredError() to AssociatedInterfacePtrController.

Indicates whether an error has been encountered by the interface endpoint
client. If true, method calls made on this interface will be dropped (and may
already have been dropped).

BUG=695635

Review-Url: https://codereview.chromium.org/2840333002
Cr-Commit-Position: refs/heads/master@{#467869}
Committed:
https://chromium.googlesource.com/chromium/src/+/2e7fbc6d817dc0307b5e64992590...
==========

[commit-bot: I haz the power, 2017-04-28 03:25:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2e7fbc6d817dc0307b5e64992590...