Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2840313002: MD Settings: user list fixes (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 7 months ago
Reviewers:
tommycli, Devlin
CC:
chromium-reviews, extensions-reviews_chromium.org, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: user list fixes This CL: * Updates the API code to make better use of user_manager::User. * Adds an isSUpervised property to usersPrivate::User. * Hides the email address for supervised users and whitelisted users not on the device (where the name is unknown). * Adds CrScrollableBehavior to the user list so that top and bottom borders for the list display properly. * Adds a requestUpdateScroll method to CrScrollableBehavior so that borders are set properly when the list updates (in addition to when it scrolls). BUG=715518 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2840313002 Cr-Commit-Position: refs/heads/master@{#468360} Committed: https://chromium.googlesource.com/chromium/src/+/a03ce481e33b012c70d864788a2c18568128d8cc

Patch Set 1 #

Patch Set 2 : Fix closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -23 lines) Patch
M chrome/browser/chromeos/extensions/users_private/users_private_api.cc View 1 chunk +18 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/people_page/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/user_list.html View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/user_list.js View 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/users_private.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/closure_compiler/externs/users_private.js View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_scrollable_behavior.js View 1 3 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
stevenjb
tommycli@ for people page JS changes and API changes rdevlin.cronin@ for .idl changes
3 years, 8 months ago (2017-04-26 21:30:25 UTC) #4
Devlin
On 2017/04/26 21:30:25, stevenjb wrote: > tommycli@ for people page JS changes and API changes ...
3 years, 8 months ago (2017-04-26 22:46:51 UTC) #5
tommycli
lgtm
3 years, 7 months ago (2017-04-28 15:46:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840313002/1
3 years, 7 months ago (2017-04-28 16:33:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/8180)
3 years, 7 months ago (2017-04-28 16:49:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840313002/20001
3 years, 7 months ago (2017-04-28 23:44:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/359929)
3 years, 7 months ago (2017-04-29 02:06:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840313002/20001
3 years, 7 months ago (2017-05-01 15:55:58 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 18:30:19 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a03ce481e33b012c70d864788a2c...

Powered by Google App Engine
This is Rietveld 408576698