Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2840263002: The constants target did not depend on the remoting_version target, so the dependencies were not ri… (Closed)

Created:
3 years, 7 months ago by nicholss
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mac-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

The constants target did not depend on the remoting_version target, so the dependencies were not right. R=sergeyu@chromium.org, rsesek@chromium.org BUG=715390 Review-Url: https://codereview.chromium.org/2840263002 Cr-Commit-Position: refs/heads/master@{#467383} Committed: https://chromium.googlesource.com/chromium/src/+/c6fb6bedc079f579abfbb45891499c0702a1ad10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M remoting/host/mac/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
nicholss
PTAL, thanks!
3 years, 7 months ago (2017-04-26 16:53:53 UTC) #2
Sergey Ulanov
lgtm
3 years, 7 months ago (2017-04-26 16:55:32 UTC) #4
Robert Sesek
lgtm
3 years, 7 months ago (2017-04-26 16:55:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840263002/1
3 years, 7 months ago (2017-04-26 18:11:39 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 18:19:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c6fb6bedc079f579abfbb4589149...

Powered by Google App Engine
This is Rietveld 408576698