Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2840213003: Move blink_perf.xml_http_request benchmark to tools/perf/contrib/ directory (Closed)

Created:
6 months, 3 weeks ago by nednguyen
Modified:
6 months, 3 weeks ago
Reviewers:
sullivan, shatch
CC:
chromium-reviews, telemetry-reviews_chromium.org, tyoshino (SeeGerritForStatus), hiroshige, martiniss
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move blink_perf.xml_http_request benchmark to tools/perf/contrib/ directory * I verified that people still be able to run "./run_benchmark --browser=system blink_perf.xml_http_request" locally. * Try bot run are in: https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_12_perf_bisect/builds/149 Other effects of this: _ People can run blink_perf.xml_http_request locally without needing to pass "--also-run-disabled-benchmark" _ The benchmarks' no-op run is no longer scheduled in perf waterfall, hence the size reduction to the testing/buildbot/chrome.perf.* files BUG=709063 Review-Url: https://codereview.chromium.org/2840213003 Cr-Commit-Position: refs/heads/master@{#467347} Committed: https://chromium.googlesource.com/chromium/src/+/bfe47df90b3d1d770f9a2dcef1bd83b966327ce4

Patch Set 1 #

Patch Set 2 : Make sure that trybot include contrib dir #

Total comments: 2

Patch Set 3 : Simplify benchmark_finders code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -1410 lines) Patch
M testing/buildbot/chromium.perf.json View 140 chunks +274 lines, -1218 lines 0 comments Download
M testing/buildbot/chromium.perf.fyi.json View 3 chunks +0 lines, -177 lines 0 comments Download
M tools/perf/benchmark.csv View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 chunk +0 lines, -7 lines 0 comments Download
A tools/perf/contrib/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/perf/contrib/blink_perf_xml_http_request/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/perf/contrib/blink_perf_xml_http_request/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/perf/core/benchmark_finders.py View 1 2 1 chunk +11 lines, -3 lines 0 comments Download
M tools/perf/core/path_util.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/core/trybot_command.py View 1 2 chunks +3 lines, -5 lines 0 comments Download
M tools/perf/run_benchmark View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 22 (12 generated)
nednguyen
6 months, 3 weeks ago (2017-04-26 14:29:29 UTC) #3
sullivan
lgtm
6 months, 3 weeks ago (2017-04-26 14:30:49 UTC) #4
shatch
*.json files lgtm
6 months, 3 weeks ago (2017-04-26 14:32:23 UTC) #6
nednguyen
On 2017/04/26 14:30:49, sullivan wrote: > lgtm Simon: can you take a look at tools/perf/core/trybot_command.py ...
6 months, 3 weeks ago (2017-04-26 14:32:24 UTC) #7
shatch
trybot_command lgtm too https://codereview.chromium.org/2840213003/diff/20001/tools/perf/core/benchmark_finders.py File tools/perf/core/benchmark_finders.py (right): https://codereview.chromium.org/2840213003/diff/20001/tools/perf/core/benchmark_finders.py#newcode48 tools/perf/core/benchmark_finders.py:48: top_level_dir = os.path.join(path_util.GetPerfDir()) nit: is this ...
6 months, 3 weeks ago (2017-04-26 14:37:31 UTC) #11
nednguyen
https://codereview.chromium.org/2840213003/diff/20001/tools/perf/core/benchmark_finders.py File tools/perf/core/benchmark_finders.py (right): https://codereview.chromium.org/2840213003/diff/20001/tools/perf/core/benchmark_finders.py#newcode48 tools/perf/core/benchmark_finders.py:48: top_level_dir = os.path.join(path_util.GetPerfDir()) On 2017/04/26 14:37:30, shatch wrote: > ...
6 months, 3 weeks ago (2017-04-26 14:42:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840213003/40001
6 months, 3 weeks ago (2017-04-26 14:43:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/202159)
6 months, 3 weeks ago (2017-04-26 16:04:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840213003/40001
6 months, 3 weeks ago (2017-04-26 16:06:20 UTC) #19
commit-bot: I haz the power
6 months, 3 weeks ago (2017-04-26 16:49:37 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bfe47df90b3d1d770f9a2dcef1bd...

Powered by Google App Engine
This is Rietveld efc10ee0f