Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2840193004: Mushrome: Use ui::InputDeviceManager in exo. (Closed)

Created:
3 years, 8 months ago by Peng
Modified:
3 years, 8 months ago
Reviewers:
kylechar, reveman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mushrome: Use ui::InputDeviceManager in exo. The ui::InputDeviceManager implementation ui::DeviceDataManager is not available in Mushrome, but another implementation ui::InputDeviceClient is avaliable in Mushrome. So we should use ui::InputDeviceManager::GetInstance() which will return correct implementation for Cash and Mushrome instead of using ui::DeviceDataManager::GetInstance(). BUG=709225 Review-Url: https://codereview.chromium.org/2840193004 Cr-Commit-Position: refs/heads/master@{#467469} Committed: https://chromium.googlesource.com/chromium/src/+/807942831018b22765df0b45bbd0d0d7deec27c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M components/exo/wm_helper_ash.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Peng
Hi Kyle, PTAL. Thanks.
3 years, 8 months ago (2017-04-26 19:00:41 UTC) #2
kylechar
lgtm
3 years, 8 months ago (2017-04-26 19:02:07 UTC) #3
Peng
Hi David, PTAL. Thanks.
3 years, 8 months ago (2017-04-26 19:03:11 UTC) #5
reveman
lgtm
3 years, 8 months ago (2017-04-26 21:14:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840193004/1
3 years, 8 months ago (2017-04-26 21:43:24 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 21:49:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/807942831018b22765df0b45bbd0...

Powered by Google App Engine
This is Rietveld 408576698