fetch: Align RequestInit's |headers| with the spec.

fetch: Align RequestInit's |headers| with the spec.

RequestInit::header is supposed to hold a HeadersInit (ie. just a WebIDL
union) object, not a fully-fledged Headers one.

Make it so, and add a HeadersInit overload to Headers::FillWith() so all the
checks for which union type is being used are centralized in one place.
Additionally, this also makes it easier to finally define RequestInit with
an IDL file in the future.

R=tyoshino@chromium.org,yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2840193002
Cr-Commit-Position: refs/heads/master@{#468309}
Committed: https://chromium.googlesource.com/chromium/src/+/51b208180cdd9881d699b7d28273d7addbce69fb

[Raphael Kubo da Costa (rakuco), 2017-04-26 11:45:24]

PTAL

[Raphael Kubo da Costa (rakuco), 2017-04-26 11:45:30]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 11:45:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 13:10:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 13:10:11]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-04-28 10:07:45]

https://codereview.chromium.org/2840193002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/fetch/Headers.h (right):

https://codereview.chromium.org/2840193002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/fetch/Headers.h:59: const
ByteStringSequenceSequenceOrByteStringByteStringRecordOrHeaders&,
Could you provide a typedef for this type? Maybe HeadersInit?

[Raphael Kubo da Costa (rakuco), 2017-05-01 09:57:12]

https://codereview.chromium.org/2840193002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/fetch/Headers.h (right):

https://codereview.chromium.org/2840193002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/fetch/Headers.h:59: const
ByteStringSequenceSequenceOrByteStringByteStringRecordOrHeaders&,
On 2017/04/28 10:07:44, yhirano wrote:
> Could you provide a typedef for this type? Maybe HeadersInit?

Done.

[Raphael Kubo da Costa (rakuco), 2017-05-01 09:57:15]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 09:57:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-05-01 10:36:40]

lgtm

https://codereview.chromium.org/2840193002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/Headers.h (right):

https://codereview.chromium.org/2840193002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/Headers.h:21: HeadersInit;
Though I call both "typedef", "using" is better, I think. Sorry for confusing
comments.

[Raphael Kubo da Costa (rakuco), 2017-05-01 10:46:33]

https://codereview.chromium.org/2840193002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/Headers.h (right):

https://codereview.chromium.org/2840193002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/Headers.h:21: HeadersInit;
On 2017/05/01 10:36:40, yhirano wrote:
> Though I call both "typedef", "using" is better, I think. Sorry for confusing
> comments.

Done too :)

[Raphael Kubo da Costa (rakuco), 2017-05-01 10:46:37]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[Raphael Kubo da Costa (rakuco), 2017-05-01 10:46:38]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2840193002/#ps40001
(title: "Use using, not typedef")

[commit-bot: I haz the power, 2017-05-01 10:46:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 12:22:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493635597536770,
"parent_rev": "a17d962424bb59e41da98acb92fc4998194de99a", "commit_rev":
"51b208180cdd9881d699b7d28273d7addbce69fb"}

[commit-bot: I haz the power, 2017-05-01 12:22:36]

Description was changed from

==========
fetch: Align RequestInit's |headers| with the spec.

RequestInit::header is supposed to hold a HeadersInit (ie. just a WebIDL
union) object, not a fully-fledged Headers one.

Make it so, and add a HeadersInit overload to Headers::FillWith() so all the
checks for which union type is being used are centralized in one place.
Additionally, this also makes it easier to finally define RequestInit with
an IDL file in the future.

R=tyoshino@chromium.org,yhirano@chromium.org
==========

to

==========
fetch: Align RequestInit's |headers| with the spec.

RequestInit::header is supposed to hold a HeadersInit (ie. just a WebIDL
union) object, not a fully-fledged Headers one.

Make it so, and add a HeadersInit overload to Headers::FillWith() so all the
checks for which union type is being used are centralized in one place.
Additionally, this also makes it easier to finally define RequestInit with
an IDL file in the future.

R=tyoshino@chromium.org,yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2840193002
Cr-Commit-Position: refs/heads/master@{#468309}
Committed:
https://chromium.googlesource.com/chromium/src/+/51b208180cdd9881d699b7d28273...
==========

[commit-bot: I haz the power, 2017-05-01 12:22:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/51b208180cdd9881d699b7d28273...