Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2840183002: [selectors4] Ship ":focus-within" pseudo-class (Closed)

Created:
3 years, 8 months ago by Manuel Rego
Modified:
3 years, 7 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[selectors4] Ship ":focus-within" pseudo-class Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V3RNBhQelSg BUG=617371 Review-Url: https://codereview.chromium.org/2840183002 Cr-Commit-Position: refs/heads/master@{#467646} Committed: https://chromium.googlesource.com/chromium/src/+/7638b8e164ca3abae4522f98a82bdb1c44b4b4cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Manuel Rego
As commented on the bug @rune is happy with shipping this: https://bugs.chromium.org/p/chromium/issues/detail?id=617371#c27 The intent thread ...
3 years, 8 months ago (2017-04-26 10:49:53 UTC) #2
rune
lgtm
3 years, 8 months ago (2017-04-26 11:39:31 UTC) #3
Manuel Rego
Actually it seems I need an API_OWNER for this change. Adding a few on CC, ...
3 years, 7 months ago (2017-04-27 08:19:05 UTC) #5
tkent
lgtm
3 years, 7 months ago (2017-04-27 08:28:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840183002/1
3 years, 7 months ago (2017-04-27 08:34:25 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 12:21:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7638b8e164ca3abae4522f98a82b...

Powered by Google App Engine
This is Rietveld 408576698