exo: Replace fling cancel with generic zero distance scroll

exo: Replace fling cancel with generic zero distance scroll

This change will suppress all fling cancel events unless the last event
was a fling event. Also it generates a proper sequence of a scroll
event with zero distance.

BUG=590754
TEST=Fling and touch the touchpad after fling. Should stop scrolling
motion in android apps.

Review-Url: https://codereview.chromium.org/2840113002
Cr-Commit-Position: refs/heads/master@{#469403}
Committed: https://chromium.googlesource.com/chromium/src/+/2df8c3016f045d03ac10f347792d65809268c980

[denniskempin (chromium), 2017-04-25 23:00:19]

denniskempin@chromium.org changed reviewers:
+ reveman@chromium.org

[denniskempin (chromium), 2017-04-25 23:00:20]

Re-upload of the really old change: https://codereview.chromium.org/2458853002/

We didn't really need it back then, but it's important for the NYC build.

[reveman, 2017-04-27 13:28:17]

https://codereview.chromium.org/2840113002/diff/1/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2840113002/diff/1/components/exo/pointer.cc#n...
components/exo/pointer.cc:215: if (last_event_type_ ==
ui::ET_SCROLL_FLING_START) {
Can you add a comment here that explains why we do this?

https://codereview.chromium.org/2840113002/diff/1/components/exo/pointer.cc#n...
components/exo/pointer.cc:216: delegate_->OnPointerScroll(event->time_stamp(),
gfx::Vector2dF(),
I think this logic deserves a comment similar to what we had in server.cc

[denniskempin (chromium), 2017-05-03 20:55:28]

PTAL again David! Thanks!

https://codereview.chromium.org/2840113002/diff/1/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2840113002/diff/1/components/exo/pointer.cc#n...
components/exo/pointer.cc:215: if (last_event_type_ ==
ui::ET_SCROLL_FLING_START) {
On 2017/04/27 13:28:17, reveman wrote:
> Can you add a comment here that explains why we do this?

Done.

https://codereview.chromium.org/2840113002/diff/1/components/exo/pointer.cc#n...
components/exo/pointer.cc:216: delegate_->OnPointerScroll(event->time_stamp(),
gfx::Vector2dF(),
On 2017/04/27 13:28:17, reveman wrote:
> I think this logic deserves a comment similar to what we had in server.cc

Done.

[reveman, 2017-05-03 21:02:49]

lgtm with small nit

https://codereview.chromium.org/2840113002/diff/40001/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2840113002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:218: // touchpad. Since it's not directly supported by
wayland, we do not
nit: we shouldn't be referring to wayland in this code. s/wayland/delegate/ is
fine.

https://codereview.chromium.org/2840113002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:222: // Since wayland does not have support for fling
cancel events
nit: s/wayland/delegate/

[denniskempin (chromium), 2017-05-03 21:26:01]

The CQ bit was checked by denniskempin@chromium.org

[denniskempin (chromium), 2017-05-03 21:26:02]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2840113002/#ps60001
(title: "fixed comments")

[commit-bot: I haz the power, 2017-05-03 21:26:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 21:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 21:55:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[denniskempin (chromium), 2017-05-04 17:32:17]

The CQ bit was checked by denniskempin@chromium.org

[denniskempin (chromium), 2017-05-04 17:32:18]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2840113002/#ps80001
(title: "fixed nit")

[commit-bot: I haz the power, 2017-05-04 17:33:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[denniskempin (chromium), 2017-05-04 18:01:48]

The CQ bit was checked by denniskempin@chromium.org

[denniskempin (chromium), 2017-05-04 18:01:48]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2840113002/#ps100001
(title: "fixed nit in test")

[commit-bot: I haz the power, 2017-05-04 18:02:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 18:52:52]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493920908247640,
"parent_rev": "5a762e451441fb1482e4b5adc274e03d4c9e6ba8", "commit_rev":
"2df8c3016f045d03ac10f347792d65809268c980"}

[commit-bot: I haz the power, 2017-05-04 18:53:05]

Description was changed from

==========
exo: Replace fling cancel with generic zero distance scroll

This change will suppress all fling cancel events unless the last event
was a fling event. Also it generates a proper sequence of a scroll
event with zero distance.

BUG=590754
TEST=Fling and touch the touchpad after fling. Should stop scrolling
motion in android apps.
==========

to

==========
exo: Replace fling cancel with generic zero distance scroll

This change will suppress all fling cancel events unless the last event
was a fling event. Also it generates a proper sequence of a scroll
event with zero distance.

BUG=590754
TEST=Fling and touch the touchpad after fling. Should stop scrolling
motion in android apps.

Review-Url: https://codereview.chromium.org/2840113002
Cr-Commit-Position: refs/heads/master@{#469403}
Committed:
https://chromium.googlesource.com/chromium/src/+/2df8c3016f045d03ac10f347792d...
==========

[commit-bot: I haz the power, 2017-05-04 18:53:07]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2df8c3016f045d03ac10f347792d...