Allow RecordingImageBufferSurface to prevent fallback.

Allow RecordingImageBufferSurface to prevent fallback.

When it will only be used for a single frame, there is no need to
fallback for complex frames. This restores behaviour for CSSPaint
module to before https://codereview.chromium.org/2833593002/.

R=ikilpatrick@chromium.org, pdr@chromium.org
TBR=senorblanco
BUG=671433
Review-Url: https://codereview.chromium.org/2840093002
Cr-Commit-Position: refs/heads/master@{#467845}
Committed: https://chromium.googlesource.com/chromium/src/+/37e6e9d2d2685dc9a6382349bd06a21837663ed2

[danakj, 2017-04-25 21:57:07]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2017-04-25 21:57:22]

Description was changed from

==========
Allow RecordingImageBufferSurface to prevent fallback.

When it will only be used for a single frame, there is no need to
fallback for complex frames.

R=ikilpatrick@chromium.org, pdr@chromium.org
BUG=671433
==========

to

==========
Allow RecordingImageBufferSurface to prevent fallback.

When it will only be used for a single frame, there is no need to
fallback for complex frames. This restores behaviour for CSSPaint
module to before https://codereview.chromium.org/2833593002/.

R=ikilpatrick@chromium.org, pdr@chromium.org
BUG=671433
==========

[commit-bot: I haz the power, 2017-04-25 21:57:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-04-25 21:59:32]

pdr: overall
ikilpatrick: csspaint

[danakj, 2017-04-25 22:02:19]

danakj@chromium.org changed reviewers:
+ senorblanco@chromium.org

[danakj, 2017-04-25 22:02:19]

+senorblanco for canvas2d (will tbr)

[commit-bot: I haz the power, 2017-04-25 22:13:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:13:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pdr., 2017-04-25 23:00:27]

https://codereview.chromium.org/2840093002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/2840093002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:956: Size(),
RecordingImageBufferSurface::kAllowFallback, opacity_mode,
Should UnacceleratedImageBufferSurface also take an allow fallback parameter? Do
we need to allow fallback for the UnacceleratedImageBufferSurface surface
created a few lines below?

[Justin Novosad, 2017-04-26 14:25:24]

junov@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2017-04-26 14:25:25]

lgtm with build fixed.

https://codereview.chromium.org/2840093002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/2840093002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:956: Size(),
RecordingImageBufferSurface::kAllowFallback, opacity_mode,
On 2017/04/25 23:00:27, pdr. wrote:
> Should UnacceleratedImageBufferSurface also take an allow fallback parameter?
Do
> we need to allow fallback for the UnacceleratedImageBufferSurface surface
> created a few lines below?

No, there is no fallback functionality in UnacceleratedImageBufferSurface

https://codereview.chromium.org/2840093002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
(right):

https://codereview.chromium.org/2840093002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp:551:
WTF::MakeUnique<RecordingImageBufferSurface>(IntSize(10, 10), kNonOpaque);
Missed this guy.

[ikilpatrick, 2017-04-26 20:36:05]

lgtm, thanks.

[pdr., 2017-04-26 20:48:08]

LGTM based on junov's response.

[danakj, 2017-04-26 22:10:10]

Description was changed from

==========
Allow RecordingImageBufferSurface to prevent fallback.

When it will only be used for a single frame, there is no need to
fallback for complex frames. This restores behaviour for CSSPaint
module to before https://codereview.chromium.org/2833593002/.

R=ikilpatrick@chromium.org, pdr@chromium.org
BUG=671433
==========

to

==========
Allow RecordingImageBufferSurface to prevent fallback.

When it will only be used for a single frame, there is no need to
fallback for complex frames. This restores behaviour for CSSPaint
module to before https://codereview.chromium.org/2833593002/.

R=ikilpatrick@chromium.org, pdr@chromium.org
TBR=senorblanco
BUG=671433
==========

[danakj, 2017-04-26 22:10:17]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-04-26 22:10:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org, pdr@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2840093002/#ps20001
(title: "imagebuffer-fallback: missedone")

[commit-bot: I haz the power, 2017-04-26 22:10:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 00:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 00:04:19]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2017-04-27 20:43:12]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:43:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:17:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493325792209680,
"parent_rev": "4f3f095f04100e1e443cfdcba1813bdaa625bc77", "commit_rev":
"37e6e9d2d2685dc9a6382349bd06a21837663ed2"}

[commit-bot: I haz the power, 2017-04-28 02:17:21]

Description was changed from

==========
Allow RecordingImageBufferSurface to prevent fallback.

When it will only be used for a single frame, there is no need to
fallback for complex frames. This restores behaviour for CSSPaint
module to before https://codereview.chromium.org/2833593002/.

R=ikilpatrick@chromium.org, pdr@chromium.org
TBR=senorblanco
BUG=671433
==========

to

==========
Allow RecordingImageBufferSurface to prevent fallback.

When it will only be used for a single frame, there is no need to
fallback for complex frames. This restores behaviour for CSSPaint
module to before https://codereview.chromium.org/2833593002/.

R=ikilpatrick@chromium.org, pdr@chromium.org
TBR=senorblanco
BUG=671433

Review-Url: https://codereview.chromium.org/2840093002
Cr-Commit-Position: refs/heads/master@{#467845}
Committed:
https://chromium.googlesource.com/chromium/src/+/37e6e9d2d2685dc9a6382349bd06...
==========

[commit-bot: I haz the power, 2017-04-28 02:17:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37e6e9d2d2685dc9a6382349bd06...