Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2840073002: Revert of [Mac] Retain location bar focus on switching to fullscreen and back. (Closed)

Created:
3 years, 8 months ago by hcarmona
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac] Retain location bar focus on switching to fullscreen and back. (patchset #4 id:60001 of https://codereview.chromium.org/2679273002/ ) Reason for revert: Suspected of causing test failures: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/40299 BrowserWindowFullScreenControllerTest.TestActivate BrowserWindowFullScreenControllerTest.TestFullscreen Original issue's description: > [Mac] Retain location bar focus on switching to fullscreen and back. > > If a window's location bar has focus before switching to fullscreen > mode, it no longer has it afterwards (and the same for the fullscreen- > to-normal transition). This cl ensures that the location bar retains > focus (if it has it) through both transitions. > > R=spqchan@chromium.org,avi@chromium.org > BUG=447740 > > Review-Url: https://codereview.chromium.org/2679273002 > Cr-Commit-Position: refs/heads/master@{#467074} > Committed: https://chromium.googlesource.com/chromium/src/+/2a657ecbdd2743e0cc7c4e5130a5b1caac88ec9e TBR=spqchan@chromium.org,avi@chromium.org,shrike@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=447740 Review-Url: https://codereview.chromium.org/2840073002 Cr-Commit-Position: refs/heads/master@{#467107} Committed: https://chromium.googlesource.com/chromium/src/+/e18d20dc507ec3937a78514d6c45a7fe485f54e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 2 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hcarmona
Created Revert of [Mac] Retain location bar focus on switching to fullscreen and back.
3 years, 8 months ago (2017-04-25 20:54:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840073002/1
3 years, 8 months ago (2017-04-25 20:54:53 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 20:55:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e18d20dc507ec3937a78514d6c45...

Powered by Google App Engine
This is Rietveld 408576698