Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2840063002: ui: Prevent DelegatedFrameHost from taking CompositorResizeLock forever (Closed)

Created:
3 years, 8 months ago by danakj
Modified:
3 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

ui: Prevent DelegatedFrameHost from taking CompositorResizeLock forever In the case where DelegatedFrameHost has no frame, it is not showing a renderer tab contents, so it does not need to try prevent guttering. However it would grab a resize lock still, in some cases where it will never be receiving a frame from the renderer. When that happens the lock times out after 67ms and it grabs it again.. forever. This causes the UI to update at 15 fps instead of 60. This fixes it by not allowing a resize lock to be grabbed when |has_frame_| is false. And when |has_frame_| changes from true to false, any current resize lock is dropped, freeing up the UI to present itself. NOTRY=true NOPRESUBMIT=true TBR=danakj BUG=712903 Review-Url: https://codereview.chromium.org/2832043002 Cr-Commit-Position: refs/heads/master@{#466508} (cherry picked from commit 8230eff799f34889d9ec93944a4e8f3147b91c17) Review-Url: https://codereview.chromium.org/2840063002 Cr-Commit-Position: refs/branch-heads/3071@{#205} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/344425197d426ed2c3f3b5527a67f98fb0d483b5

Patch Set 1 #

Patch Set 2 : ui: Prevent DelegatedFrameHost from taking CompositorResizeLock forever #

Patch Set 3 : ui: Prevent DelegatedFrameHost from taking CompositorResizeLock forever #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M content/browser/renderer_host/delegated_frame_host.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
danakj
LGTM
3 years, 8 months ago (2017-04-25 20:57:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840063002/20001
3 years, 8 months ago (2017-04-25 21:01:01 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 8 months ago (2017-04-25 21:01:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840063002/20001
3 years, 8 months ago (2017-04-25 21:04:32 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 21:08:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/344425197d426ed2c3f3b5527a67...

Powered by Google App Engine
This is Rietveld 408576698