Chromium Code Reviews
Descriptionui: Prevent DelegatedFrameHost from taking CompositorResizeLock forever
In the case where DelegatedFrameHost has no frame, it is not showing
a renderer tab contents, so it does not need to try prevent guttering.
However it would grab a resize lock still, in some cases where it will
never be receiving a frame from the renderer. When that happens the
lock times out after 67ms and it grabs it again.. forever. This causes
the UI to update at 15 fps instead of 60.
This fixes it by not allowing a resize lock to be grabbed when
|has_frame_| is false. And when |has_frame_| changes from true to
false, any current resize lock is dropped, freeing up the UI to
present itself.
NOTRY=true
NOPRESUBMIT=true
TBR=danakj
BUG=712903
Review-Url: https://codereview.chromium.org/2832043002
Cr-Commit-Position: refs/heads/master@{#466508}
(cherry picked from commit 8230eff799f34889d9ec93944a4e8f3147b91c17)
Review-Url: https://codereview.chromium.org/2840063002
Cr-Commit-Position: refs/branch-heads/3071@{#205}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/344425197d426ed2c3f3b5527a67f98fb0d483b5
Patch Set 1 #Patch Set 2 : ui: Prevent DelegatedFrameHost from taking CompositorResizeLock forever #Patch Set 3 : ui: Prevent DelegatedFrameHost from taking CompositorResizeLock forever #
Messages
Total messages: 11 (6 generated)
|
|||||||||||||||||||||||||||||||||||||