auth_service: Fetch revisions of all configs (for UI) at once.

auth_service: Fetch revisions of all configs (for UI) at once.

Also, do it in parallel. This will simplify the switch to client-side Single
Page Application by removing the need for per-tab callback (info for all tabs
will be fetched at once).

R=nodir@chromium.org
BUG=714821
Review-Url: https://codereview.chromium.org/2840053003
Committed: https://github.com/luci/luci-py/commit/872b28d8137e4f2211c32e549c4402085ed039fc

[Vadim Sh., 2017-04-25 23:17:40]

PTAL

Deployed here:
https://2771-a51c5be-tainted-vadimsh-dot-chrome-infra-auth-dev.appspot.com/au...

https://codereview.chromium.org/2840053003/diff/1/appengine/components/compon...
File appengine/components/components/auth/ui/templates/base.html (right):

https://codereview.chromium.org/2840053003/diff/1/appengine/components/compon...
appengine/components/components/auth/ui/templates/base.html:48: {# Used on
auth_service if config_service is managing configs #}
note: this will be done in Javascript later

[nodir, 2017-04-28 17:49:24]

lgtm

https://codereview.chromium.org/2840053003/diff/1/appengine/auth_service/hand...
File appengine/auth_service/handlers_frontend.py (right):

https://codereview.chromium.org/2840053003/diff/1/appengine/auth_service/hand...
appengine/auth_service/handlers_frontend.py:86: 'auth_service_config_revisions':
config_revisions,
`auth_service_configs`?
because there is URL and you can add more stuff later

https://codereview.chromium.org/2840053003/diff/1/appengine/components/compon...
File appengine/components/components/auth/ui/templates/base.html (right):

https://codereview.chromium.org/2840053003/diff/1/appengine/components/compon...
appengine/components/components/auth/ui/templates/base.html:50: {% set rev =
auth_service_config_revisions[config_path] %}
I think this is config, not rev. `cfg`?

https://codereview.chromium.org/2840053003/diff/1/appengine/components/compon...
File appengine/components/components/auth/ui/ui.py (right):

https://codereview.chromium.org/2840053003/diff/1/appengine/components/compon...
appengine/components/components/auth/ui/ui.py:47: additional data to return to
authenticated users. It can be used by
FWIU additional data is sent to non-authenticated users too

[Vadim Sh., 2017-04-29 01:59:10]

https://codereview.chromium.org/2840053003/diff/1/appengine/auth_service/hand...
File appengine/auth_service/handlers_frontend.py (right):

https://codereview.chromium.org/2840053003/diff/1/appengine/auth_service/hand...
appengine/auth_service/handlers_frontend.py:86: 'auth_service_config_revisions':
config_revisions,
On 2017/04/28 17:49:24, nodir wrote:
> `auth_service_configs`?
> because there is URL and you can add more stuff later

Done.

https://codereview.chromium.org/2840053003/diff/1/appengine/components/compon...
File appengine/components/components/auth/ui/templates/base.html (right):

https://codereview.chromium.org/2840053003/diff/1/appengine/components/compon...
appengine/components/components/auth/ui/templates/base.html:50: {% set rev =
auth_service_config_revisions[config_path] %}
On 2017/04/28 17:49:24, nodir wrote:
> I think this is config, not rev. `cfg`?

This specifies SHA1 of the config commit and an URL to this commit in gitiles.
So it is more a revision that config.

https://codereview.chromium.org/2840053003/diff/1/appengine/components/compon...
File appengine/components/components/auth/ui/ui.py (right):

https://codereview.chromium.org/2840053003/diff/1/appengine/components/compon...
appengine/components/components/auth/ui/ui.py:47: additional data to return to
authenticated users. It can be used by
On 2017/04/28 17:49:24, nodir wrote:
> FWIU additional data is sent to non-authenticated users too

No, it doesn't. All auth pages require authentication and accessible only to
accounts that pass 'acl.has_access' check.

I've added this comment because later the base HTML templates will be accessible
to anonymous users (but the data returned by ui_data_callback will still
accessible only to authorized users).

[Vadim Sh., 2017-05-01 18:56:57]

The CQ bit was checked by vadimsh@chromium.org

[Vadim Sh., 2017-05-01 18:56:57]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2840053003/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-05-01 18:57:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:59:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493665017376930,
"parent_rev": "b240f904fee39a33b6b10b7cdb16bcd75b8ebdf9", "commit_rev":
"872b28d8137e4f2211c32e549c4402085ed039fc"}

[commit-bot: I haz the power, 2017-05-01 18:59:22]

Description was changed from

==========
auth_service: Fetch revisions of all configs (for UI) at once.

Also, do it in parallel. This will simplify the switch to client-side Single
Page Application by removing the need for per-tab callback (info for all tabs
will be fetched at once).

R=nodir@chromium.org
BUG=714821
==========

to

==========
auth_service: Fetch revisions of all configs (for UI) at once.

Also, do it in parallel. This will simplify the switch to client-side Single
Page Application by removing the need for per-tab callback (info for all tabs
will be fetched at once).

R=nodir@chromium.org
BUG=714821

Review-Url: https://codereview.chromium.org/2840053003
Committed:
https://github.com/luci/luci-py/commit/872b28d8137e4f2211c32e549c4402085ed039fc
==========

[commit-bot: I haz the power, 2017-05-01 18:59:23]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/872b28d8137e4f2211c32e549c4402085ed039fc