Fix button event on mouse events.

Fix button event on mouse events.

Button is supposed to be uninitialized on events that are
mousemove,leave,enter,over and out.

This matches FF and Edge.

BUG=650704
Review-Url: https://codereview.chromium.org/2840023002
Cr-Commit-Position: refs/heads/master@{#467486}
Committed: https://chromium.googlesource.com/chromium/src/+/bafc23e1920cc799c03159c39e29878e26071db0

[dtapuska, 2017-04-25 15:30:02]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 15:30:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2017-04-25 15:30:16]

dtapuska@chromium.org changed reviewers:
+ nzolghadr@chromium.org

[Navid Zolghadr, 2017-04-25 15:45:09]

lgtm

https://codereview.chromium.org/2840023002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/uievents/mouse/mouseevent_move_button-manual.html
(right):

https://codereview.chromium.org/2840023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/uievents/mouse/mouseevent_move_button-manual.html:31:
<li>Press a non-primary button and hold it</li>
nit: Since you are asking for any non-primary button do you like to
preventDefault contextmenu event so that it works for right button on Chrome as
well?

https://codereview.chromium.org/2840023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/uievents/mouse/mouseevent_move_button-manual.html:55:
on_event(lightgreen, "click", function (event) {
nit: Although our current implementation sends the click event to the green div
but this is unfair to assume tha is right. How about adding this listener to the
yellow div and it should still work just fine?

[commit-bot: I haz the power, 2017-04-25 17:16:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 17:16:08]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dtapuska, 2017-04-25 17:38:31]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[dtapuska, 2017-04-25 17:38:44]

https://codereview.chromium.org/2840023002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/uievents/mouse/mouseevent_move_button-manual.html
(right):

https://codereview.chromium.org/2840023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/uievents/mouse/mouseevent_move_button-manual.html:31:
<li>Press a non-primary button and hold it</li>
On 2017/04/25 15:45:08, Navid Zolghadr wrote:
> nit: Since you are asking for any non-primary button do you like to
> preventDefault contextmenu event so that it works for right button on Chrome
as
> well?

Done.

https://codereview.chromium.org/2840023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/uievents/mouse/mouseevent_move_button-manual.html:55:
on_event(lightgreen, "click", function (event) {
On 2017/04/25 15:45:09, Navid Zolghadr wrote:
> nit: Although our current implementation sends the click event to the green
div
> but this is unfair to assume tha is right. How about adding this listener to
the
> yellow div and it should still work just fine?

Done.

[commit-bot: I haz the power, 2017-04-25 17:38:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 19:17:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 19:17:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dtapuska, 2017-04-26 18:27:12]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:28:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 20:55:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 20:55:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dtapuska, 2017-04-26 21:33:06]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2017-04-26 21:33:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
nzolghadr@chromium.org
Link to the patchset: https://codereview.chromium.org/2840023002/#ps40001
(title: "Fix button event on mouse events.")

[commit-bot: I haz the power, 2017-04-26 21:34:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 22:37:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493242386660240,
"parent_rev": "27b41b0b6fb0317aa944f2bdf7e4879628aab83c", "commit_rev":
"bafc23e1920cc799c03159c39e29878e26071db0"}

[commit-bot: I haz the power, 2017-04-26 22:37:41]

Description was changed from

==========
Fix button event on mouse events.

Button is supposed to be uninitialized on events that are
mousemove,leave,enter,over and out.

This matches FF and Edge.

BUG=650704
==========

to

==========
Fix button event on mouse events.

Button is supposed to be uninitialized on events that are
mousemove,leave,enter,over and out.

This matches FF and Edge.

BUG=650704

Review-Url: https://codereview.chromium.org/2840023002
Cr-Commit-Position: refs/heads/master@{#467486}
Committed:
https://chromium.googlesource.com/chromium/src/+/bafc23e1920cc799c03159c39e29...
==========

[commit-bot: I haz the power, 2017-04-26 22:37:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bafc23e1920cc799c03159c39e29...