Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2840013004: Add CRWWebViewScrollViewProxy.dragging which will be used in (Closed)

Created:
3 years, 8 months ago by Hiroshi Ichikawa
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CRWWebViewScrollViewProxy.dragging which will be used in CWVScrollView. BUG=714543 Review-Url: https://codereview.chromium.org/2840013004 Cr-Commit-Position: refs/heads/master@{#467560} Committed: https://chromium.googlesource.com/chromium/src/+/5ecb75c280ef3f9b1840a19305d6d9b5482ffe76

Patch Set 1 #

Patch Set 2 : Add test. #

Total comments: 4

Patch Set 3 : Apply review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ios/web/public/web_state/ui/crw_web_view_scroll_view_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_view_scroll_view_proxy.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2842953002 Patch 40001

Messages

Total messages: 12 (5 generated)
Hiroshi Ichikawa
3 years, 8 months ago (2017-04-26 05:39:39 UTC) #2
Eugene But (OOO till 7-30)
Please add CRWWebViewScrollViewProxyTest unit test to your change
3 years, 8 months ago (2017-04-26 05:43:25 UTC) #3
Hiroshi Ichikawa
On 2017/04/26 05:43:25, Eugene But wrote: > Please add CRWWebViewScrollViewProxyTest unit test to your change ...
3 years, 8 months ago (2017-04-26 06:14:26 UTC) #4
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2840013004/diff/20001/ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm File ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm (right): https://codereview.chromium.org/2840013004/diff/20001/ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm#newcode105 ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm:105: [[[mockScrollView_ expect] andReturnValue:[NSNumber numberWithBool:YES]] s/[NSNumber numberWithBool:YES]/@YES https://codereview.chromium.org/2840013004/diff/20001/ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm#newcode109 ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm:109: ...
3 years, 8 months ago (2017-04-26 17:23:07 UTC) #5
Hiroshi Ichikawa
https://codereview.chromium.org/2840013004/diff/20001/ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm File ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm (right): https://codereview.chromium.org/2840013004/diff/20001/ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm#newcode105 ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm:105: [[[mockScrollView_ expect] andReturnValue:[NSNumber numberWithBool:YES]] On 2017/04/26 17:23:07, Eugene But ...
3 years, 8 months ago (2017-04-27 02:00:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840013004/40001
3 years, 8 months ago (2017-04-27 02:02:42 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 03:08:02 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5ecb75c280ef3f9b1840a19305d6...

Powered by Google App Engine
This is Rietveld 408576698