Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2840013002: [Web Payments] Layout sheets after the width of their parent is known (Closed)

Created:
3 years, 8 months ago by anthonyvd
Modified:
3 years, 8 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Layout sheets after the width of their parent is known BUG=715119 Review-Url: https://codereview.chromium.org/2840013002 Cr-Commit-Position: refs/heads/master@{#467321} Committed: https://chromium.googlesource.com/chromium/src/+/58fc6423623338c40b476df00c50b9f964330ff2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
anthonyvd
Hi Math, can you PTAL? This fixes the CVC sheet clipping we discuss and makes ...
3 years, 8 months ago (2017-04-25 15:29:38 UTC) #2
anthonyvd
Friendly ping!
3 years, 8 months ago (2017-04-26 13:11:31 UTC) #3
Mathieu
lgtm + question https://codereview.chromium.org/2840013002/diff/1/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc File chrome/browser/ui/views/payments/payment_request_sheet_controller.cc (right): https://codereview.chromium.org/2840013002/diff/1/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc#newcode32 chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:32: content_view_ = new views::View; I'm wondering ...
3 years, 8 months ago (2017-04-26 13:17:06 UTC) #4
anthonyvd
https://codereview.chromium.org/2840013002/diff/1/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc File chrome/browser/ui/views/payments/payment_request_sheet_controller.cc (right): https://codereview.chromium.org/2840013002/diff/1/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc#newcode32 chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:32: content_view_ = new views::View; On 2017/04/26 at 13:17:06, Mathieu ...
3 years, 8 months ago (2017-04-26 13:33:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840013002/20001
3 years, 8 months ago (2017-04-26 13:34:07 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 14:26:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/58fc6423623338c40b476df00c50...

Powered by Google App Engine
This is Rietveld 408576698