[Web Payments] Layout sheets after the width of their parent is known

[Web Payments] Layout sheets after the width of their parent is known

BUG=715119
Review-Url: https://codereview.chromium.org/2840013002
Cr-Commit-Position: refs/heads/master@{#467321}
Committed: https://chromium.googlesource.com/chromium/src/+/58fc6423623338c40b476df00c50b9f964330ff2

[anthonyvd, 2017-04-25 15:29:38]

anthonyvd@chromium.org changed reviewers:
+ mathp@chromium.org

[anthonyvd, 2017-04-25 15:29:38]

Hi Math, can you PTAL? 

This fixes the CVC sheet clipping we discuss and makes sure the same thing won't
happen with other sheets that have multiline labels.

Thanks!

[anthonyvd, 2017-04-26 13:11:31]

Friendly ping!

[Mathieu, 2017-04-26 13:17:06]

lgtm + question

https://codereview.chromium.org/2840013002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
(right):

https://codereview.chromium.org/2840013002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:32:
content_view_ = new views::View;
I'm wondering if this line can be inside CreatePaymentView?

[anthonyvd, 2017-04-26 13:33:45]

https://codereview.chromium.org/2840013002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
(right):

https://codereview.chromium.org/2840013002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:32:
content_view_ = new views::View;
On 2017/04/26 at 13:17:06, Mathieu wrote:
> I'm wondering if this line can be inside CreatePaymentView?

Great point, done.

[anthonyvd, 2017-04-26 13:33:46]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2017-04-26 13:33:46]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2840013002/#ps20001
(title: "Address comment.")

[commit-bot: I haz the power, 2017-04-26 13:34:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 14:26:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493213626429760,
"parent_rev": "c756f829942e5160b135e337d6408047346aa133", "commit_rev":
"58fc6423623338c40b476df00c50b9f964330ff2"}

[commit-bot: I haz the power, 2017-04-26 14:26:38]

Description was changed from

==========
[Web Payments] Layout sheets after the width of their parent is known

BUG=715119
==========

to

==========
[Web Payments] Layout sheets after the width of their parent is known

BUG=715119

Review-Url: https://codereview.chromium.org/2840013002
Cr-Commit-Position: refs/heads/master@{#467321}
Committed:
https://chromium.googlesource.com/chromium/src/+/58fc6423623338c40b476df00c50...
==========

[commit-bot: I haz the power, 2017-04-26 14:26:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/58fc6423623338c40b476df00c50...