[Android] Adding Smart GO/NEXT feature in Chrome

third_party/WebKit/Source/web/WebViewImpl.cpp

Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index cfffa16ef8bdef43e5d75dfa52a346acd4d5d471..9706d77eee93fee515cad2a11807eab8c7e9368c 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2900,6 +2900,23 @@ void WebViewImpl::advanceFocus(bool reverse) {
                                                  : WebFocusTypeForward);
 }
 
+void WebViewImpl::advanceFocusInForm(WebFocusType focusType) {
+  Element* element = focusedElement();
+  if (!element)
+    return;
+
+  LocalFrame* focusedFrame = focusedLocalFrameInWidget();

[EhsanK, 2017/04/25 22:43:08]

I may not be understanding the patch correctly but I think this should be an
early return if |focusedFrame| is not the same as the render frame which
received the IPC.

[AKVT, 2017/04/26 10:33:04]

Could you help me to find an example in this file which is taking care of this
scenario ?

Currently, I have updated with active frame while I moved the changes in
WebLocalFrameImpl.cpp

[EhsanK, 2017/04/26 21:31:59]

New changes in RenderFrameImpl and WebLocalFrame look good to me. Left some
comments there about the focus issue. In short, I don't think it is really
something to worry about.

+  if (focusedFrame) {
+    Element* nextElement =
+        focusedFrame->inputMethodController().nextFocusableElementInForm(
+            element, focusType);
+    if (!nextElement)
+      return;
+    nextElement->scrollIntoViewIfNeeded(true /*centerIfNeeded*/);
+    nextElement->focus();
+  }
+}
+
 void WebViewImpl::advanceFocusAcrossFrames(WebFocusType type,
                                            WebRemoteFrame* from,
                                            WebLocalFrame* to) {