[Android] Adding Smart GO/NEXT feature in Chrome

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 2882 matching lines @@
                                      caretInDocument.height() + caretPadding -
                                      targetViewportSize.height()));
   }
 }
 
 void WebViewImpl::advanceFocus(bool reverse) {
   page()->focusController().advanceFocus(reverse ? WebFocusTypeBackward
                                                  : WebFocusTypeForward);
 }
 
+void WebViewImpl::advanceFocusInForm(WebFocusType focusType) {
+  Element* element = focusedElement();
+  if (!element)
+    return;
+
+  LocalFrame* focusedFrame = focusedLocalFrameInWidget();

[EhsanK, 2017/04/25 22:43:08]

I may not be understanding the patch correctly but I think this should be an
early return if |focusedFrame| is not the same as the render frame which
received the IPC.

[AKVT, 2017/04/26 10:33:04]

Could you help me to find an example in this file which is taking care of this
scenario ?

Currently, I have updated with active frame while I moved the changes in
WebLocalFrameImpl.cpp

[EhsanK, 2017/04/26 21:31:59]

New changes in RenderFrameImpl and WebLocalFrame look good to me. Left some
comments there about the focus issue. In short, I don't think it is really
something to worry about.

+  if (focusedFrame) {
+    Element* nextElement =
+        focusedFrame->inputMethodController().nextFocusableElementInForm(
+            element, focusType);
+    if (!nextElement)
+      return;
+    nextElement->scrollIntoViewIfNeeded(true /*centerIfNeeded*/);
+    nextElement->focus();
+  }
+}
+
 void WebViewImpl::advanceFocusAcrossFrames(WebFocusType type,
                                            WebRemoteFrame* from,
                                            WebLocalFrame* to) {
   // TODO(alexmos): Pass in proper with sourceCapabilities.
   page()->focusController().advanceFocusAcrossFrames(
       type, toWebRemoteFrameImpl(from)->frame(),
       toWebLocalFrameImpl(to)->frame());
 }
 
 double WebViewImpl::zoomLevel() {
@@ skipping 1265 matching lines @@
   if (focusedFrame->localFrameRoot() != mainFrameImpl()->frame())
     return nullptr;
   return focusedFrame;
 }
 
 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const {
   return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr;
 }
 
 }  // namespace blink