[Android] Adding Smart GO/NEXT feature in Chrome

content/browser/android/ime_adapter_android.cc

Index: content/browser/android/ime_adapter_android.cc
diff --git a/content/browser/android/ime_adapter_android.cc b/content/browser/android/ime_adapter_android.cc
index 695e53727c802388abe4594840a74010db712c56..8dbd4b1dae51df605c40ee97cbf05662733f60c0 100644
--- a/content/browser/android/ime_adapter_android.cc
+++ b/content/browser/android/ime_adapter_android.cc
@@ -20,6 +20,7 @@
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 #include "content/browser/web_contents/web_contents_impl.h"
+#include "content/common/frame_messages.h"
 #include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/browser_thread.h"
@@ -303,6 +304,16 @@ void ImeAdapterAndroid::FocusedNodeChanged(bool is_editable_node) {
   }
 }
 
+void ImeAdapterAndroid::AdvanceFocusInForm(JNIEnv* env,
+                                           const JavaParamRef<jobject>& obj,
+                                           jboolean forward) {
+  RenderFrameHost* rfh = GetFocusedFrame();
+  if (!rfh)
+    return;
+
+  rfh->Send(new FrameMsg_AdvanceFocusInForm(rfh->GetRoutingID(), forward));

[EhsanK, 2017/04/25 22:43:08]

Is it important if this message arrives out of order with respect to an
InputMsg_HandleInputEvent message which was sent before or after it (we send
those through the call to SendKeyEvent)? I believe (sometimes) we cannot
guarantee the order of arrival between some InputMsg and FrameMsg:
https://cs.chromium.org/chromium/src/content/renderer/input/input_event_filte...

[AKVT, 2017/04/26 10:33:04]

If that's a problematic situation, could you help me how we can safeguard it
gracefully ?

[EhsanK, 2017/04/26 21:31:59]

I suggest making the IPC an InputMsg instead. I am referring to this line of
code:
https://cs.chromium.org/chromium/src/content/renderer/input/input_event_filte...

Where it seems like InputMsg's go through a different path (most if not all
messages sent by this class seem to be InputMsg).

I suggest consulting someone more familiar with input about this, perhaps
chongz@ (who is also familiar with InputMethodController.* fiels).

[AKVT, 2017/04/27 15:07:02]

Thank you for your suggestion. I will wait for respective file owner comments to
get more clarity before I make a change corresponds to this.

+ }
+
 void ImeAdapterAndroid::SetEditableSelectionOffsets(
     JNIEnv*,
     const JavaParamRef<jobject>&,