[Android] Adding Smart GO/NEXT feature in Chrome

content/browser/android/ime_adapter_android.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/ime_adapter_android.h"
 
 #include <android/input.h>
 #include <algorithm>
 #include <vector>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "content/browser/frame_host/interstitial_page_impl.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_delegate.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 #include "content/browser/web_contents/web_contents_impl.h"
+#include "content/common/frame_messages.h"
 #include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/web_contents.h"
 #include "jni/ImeAdapter_jni.h"
 #include "third_party/WebKit/public/platform/WebInputEvent.h"
 #include "third_party/WebKit/public/platform/WebTextInputType.h"
 #include "third_party/WebKit/public/web/WebCompositionUnderline.h"
 
@@ skipping 263 matching lines @@
 }
 
 void ImeAdapterAndroid::FocusedNodeChanged(bool is_editable_node) {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = java_ime_adapter_.get(env);
   if (!obj.is_null()) {
     Java_ImeAdapter_focusedNodeChanged(env, obj, is_editable_node);
   }
 }
 
+void ImeAdapterAndroid::AdvanceFocusInForm(JNIEnv* env,
+                                           const JavaParamRef<jobject>& obj,
+                                           jboolean forward) {
+  RenderFrameHost* rfh = GetFocusedFrame();
+  if (!rfh)
+    return;
+
+  rfh->Send(new FrameMsg_AdvanceFocusInForm(rfh->GetRoutingID(), forward));

[EhsanK, 2017/04/25 22:43:08]

Is it important if this message arrives out of order with respect to an
InputMsg_HandleInputEvent message which was sent before or after it (we send
those through the call to SendKeyEvent)? I believe (sometimes) we cannot
guarantee the order of arrival between some InputMsg and FrameMsg:
https://cs.chromium.org/chromium/src/content/renderer/input/input_event_filte...

[AKVT, 2017/04/26 10:33:04]

If that's a problematic situation, could you help me how we can safeguard it
gracefully ?

[EhsanK, 2017/04/26 21:31:59]

I suggest making the IPC an InputMsg instead. I am referring to this line of
code:
https://cs.chromium.org/chromium/src/content/renderer/input/input_event_filte...

Where it seems like InputMsg's go through a different path (most if not all
messages sent by this class seem to be InputMsg).

I suggest consulting someone more familiar with input about this, perhaps
chongz@ (who is also familiar with InputMethodController.* fiels).

[AKVT, 2017/04/27 15:07:02]

Thank you for your suggestion. I will wait for respective file owner comments to
get more clarity before I make a change corresponds to this.

+ }
+
 void ImeAdapterAndroid::SetEditableSelectionOffsets(
     JNIEnv*,
     const JavaParamRef<jobject>&,
     int start,
     int end) {
   RenderFrameHost* rfh = GetFocusedFrame();
   if (!rfh)
     return;
 
   rfh->Send(new InputMsg_SetEditableSelectionOffsets(rfh->GetRoutingID(), start,
@@ skipping 118 matching lines @@
   Java_ImeAdapter_populateUnderlinesFromSpans(
       env, obj, text, reinterpret_cast<jlong>(&underlines));
 
   // Sort spans by |.startOffset|.
   std::sort(underlines.begin(), underlines.end());
 
   return underlines;
 }
 
 }  // namespace content