Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2839933005: mash: Merge ChromeLauncherController and *Impl subclass. (Closed)

Created:
3 years, 8 months ago by msw
Modified:
3 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Merge ChromeLauncherController and *Impl subclass. Combine the base class and only remaining subclass. Simplify: -Remove some unnecessary accessors for the subclass. -Merge constructors, destructors, Init/OnInit, OnAppImageUpdated. -Make some CLC base classes and functions private. -Remove unused includes. Rename test files and classes. BUG=557406 TEST=No functional changes; refactoring only. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2839933005 Cr-Commit-Position: refs/heads/master@{#467557} Committed: https://chromium.googlesource.com/chromium/src/+/5c06364c55d30f7d4d3014fd02d66b88aad962c1

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Cleanup #

Total comments: 18

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1786 lines, -8731 lines) Patch
M ash/shell.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_controller.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_launcher_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 2 3 9 chunks +245 lines, -84 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 3 6 chunks +1315 lines, -16 lines 0 comments Download
A + chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 3 20 chunks +30 lines, -42 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h View 1 chunk +0 lines, -286 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 chunk +0 lines, -1356 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 chunk +0 lines, -2418 lines 0 comments Download
D chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +0 lines, -4315 lines 0 comments Download
A + chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 2 3 83 chunks +130 lines, -144 lines 0 comments Download
M chrome/browser/ui/ash/launcher/desktop_shell_launcher_context_menu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/desktop_shell_launcher_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/extension_launcher_context_menu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
msw
Hey James, please take a look; thanks!
3 years, 8 months ago (2017-04-26 21:41:01 UTC) #6
James Cook
Nice! Good to see the number of classes going down. LGTM with nits. https://codereview.chromium.org/2839933005/diff/40001/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc File ...
3 years, 8 months ago (2017-04-26 22:17:13 UTC) #8
msw
https://codereview.chromium.org/2839933005/diff/40001/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right): https://codereview.chromium.org/2839933005/diff/40001/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc#newcode211 chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:211: if (arc::IsArcAllowedForProfile(this->profile())) On 2017/04/26 22:17:12, James Cook wrote: > ...
3 years, 8 months ago (2017-04-26 23:20:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839933005/60001
3 years, 8 months ago (2017-04-26 23:20:43 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 02:49:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5c06364c55d30f7d4d3014fd02d6...

Powered by Google App Engine
This is Rietveld 408576698