Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2839933003: [builtins] Builtins::CallableFor(): generate CPP case for ConsoleAssert only. (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Builtins::CallableFor(): generate CPP case for ConsoleAssert only. To reduce size of Builtins::CallableFor function we can add only case which we actually use. BUG=chromium:714893 R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2839933003 Cr-Commit-Position: refs/heads/master@{#44900} Committed: https://chromium.googlesource.com/v8/v8/+/a1a3090479cf8da10a2376f58ef2f33cc045eedb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/builtins/builtins.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kozy
Igor, please take a look. I got a binary size regression issue (crbug.com/714893) and I ...
3 years, 8 months ago (2017-04-25 19:29:21 UTC) #1
Igor Sheludko
lgtm
3 years, 8 months ago (2017-04-26 08:52:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839933003/1
3 years, 8 months ago (2017-04-26 15:15:57 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 15:40:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a1a3090479cf8da10a2376f58ef2f33cc04...

Powered by Google App Engine
This is Rietveld 408576698