Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2839923002: [regexp] Fix unicode escapes in test strings (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix unicode escapes in test strings Some of these tests pass the pattern as a string, and in this case there's a subtle distinction between "/\u{0041}/" // Unicode escape interpreted in string literal. and "/\\u{0041}/" // Unicode escape interpreted by regexp parser. Extend these tests to check both cases. Thanks littledan@ for pointing this out. BUG=v8:5437 Review-Url: https://codereview.chromium.org/2839923002 Cr-Commit-Position: refs/heads/master@{#44840} Committed: https://chromium.googlesource.com/v8/v8/+/9372dd95d9f9c855e8b7b17e840b6205b60ee328

Patch Set 1 #

Patch Set 2 : Add tests for non-bracketed escapes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M test/mjsunit/harmony/regexp-named-captures.js View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jgruber
3 years, 8 months ago (2017-04-25 10:56:15 UTC) #6
Dan Ehrenberg
lgtm
3 years, 8 months ago (2017-04-25 11:08:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839923002/20001
3 years, 8 months ago (2017-04-25 11:16:19 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/9372dd95d9f9c855e8b7b17e840b6205b60ee328
3 years, 8 months ago (2017-04-25 11:20:42 UTC) #14
Yang
3 years, 8 months ago (2017-04-25 11:22:44 UTC) #15
Message was sent while issue was closed.
On 2017/04/25 11:20:42, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/v8/v8/+/9372dd95d9f9c855e8b7b17e840b6205b60...

lgtm.

Powered by Google App Engine
This is Rietveld 408576698