Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2839903003: ValueSerializer: Add a warning about making wire format changes near branch. (Closed)

Created:
3 years, 8 months ago by jbroman
Modified:
3 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
jbroman+watch_chromium.org, v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

ValueSerializer: Add a warning about making wire format changes near branch. BUG=chromium:715232 Review-Url: https://codereview.chromium.org/2839903003 Cr-Commit-Position: refs/heads/master@{#44947} Committed: https://chromium.googlesource.com/v8/v8/+/0f82f0d3a4a761a944bb4f5a4153ea2f062c0269

Patch Set 1 #

Patch Set 2 : update wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/value-serializer.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jbroman
Similar Chromium-side change is here: https://codereview.chromium.org/2844543002
3 years, 8 months ago (2017-04-25 20:01:40 UTC) #4
jbroman
ping
3 years, 7 months ago (2017-04-27 14:44:11 UTC) #9
Jakob Kummerow
lgtm
3 years, 7 months ago (2017-04-27 14:59:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839903003/20001
3 years, 7 months ago (2017-04-27 15:09:14 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 15:39:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0f82f0d3a4a761a944bb4f5a4153ea2f062...

Powered by Google App Engine
This is Rietveld 408576698