Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2839873004: [turbofan] Fix buggy implicit coercion in GetMapWitness. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix buggy implicit coercion in GetMapWitness. BUG=chromium:715151 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2839873004 Cr-Commit-Position: refs/heads/master@{#44881} Committed: https://chromium.googlesource.com/v8/v8/+/e913f9e3842dbbd3d87a54013f4f93ac723ba735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-715151.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-26 08:59:26 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-26 09:55:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839873004/1
3 years, 8 months ago (2017-04-26 09:56:24 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 09:57:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e913f9e3842dbbd3d87a54013f4f93ac723...

Powered by Google App Engine
This is Rietveld 408576698