Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 2839843002: Android URL formatting: Disable RTL URLs for Android 4.2 and below. (Closed)

Created:
3 years, 8 months ago by tommycli
Modified:
3 years, 7 months ago
Reviewers:
Ted C, Matt Giuca
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android URL formatting: Disable RTL URLs for Android 4.2 and below. Android 4.2 and below has a problematic RTL implementation. Force formatted URLs to display in LTR. BUG=709417 Review-Url: https://codereview.chromium.org/2839843002 Cr-Commit-Position: refs/heads/master@{#467740} Committed: https://chromium.googlesource.com/chromium/src/+/e1fa8fc5972327ce78225c7de95153c63d3e3bb3

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Total comments: 4

Patch Set 3 : make constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java View 1 2 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
tommycli
mgiuca: PTAL, This CL contains a possible fix, but it's probably not quite right. I ...
3 years, 8 months ago (2017-04-25 00:06:21 UTC) #6
Matt Giuca
https://codereview.chromium.org/2839843002/diff/1/components/url_formatter/url_formatter.cc File components/url_formatter/url_formatter.cc (right): https://codereview.chromium.org/2839843002/diff/1/components/url_formatter/url_formatter.cc#newcode837 components/url_formatter/url_formatter.cc:837: url_string = base::i18n::GetDisplayStringInLTRDirectionality(url_string); On 2017/04/25 00:06:21, tommycli wrote: > ...
3 years, 8 months ago (2017-04-26 00:01:05 UTC) #7
Matt Giuca
https://codereview.chromium.org/2839843002/diff/1/components/url_formatter/url_formatter.cc File components/url_formatter/url_formatter.cc (right): https://codereview.chromium.org/2839843002/diff/1/components/url_formatter/url_formatter.cc#newcode837 components/url_formatter/url_formatter.cc:837: url_string = base::i18n::GetDisplayStringInLTRDirectionality(url_string); On 2017/04/26 00:01:05, Matt Giuca wrote: ...
3 years, 8 months ago (2017-04-26 05:57:09 UTC) #8
tommycli
matt: PTAL again, thanks! https://codereview.chromium.org/2839843002/diff/1/components/url_formatter/url_formatter.cc File components/url_formatter/url_formatter.cc (right): https://codereview.chromium.org/2839843002/diff/1/components/url_formatter/url_formatter.cc#newcode837 components/url_formatter/url_formatter.cc:837: url_string = base::i18n::GetDisplayStringInLTRDirectionality(url_string); On 2017/04/26 ...
3 years, 8 months ago (2017-04-27 01:36:34 UTC) #12
Matt Giuca
https://codereview.chromium.org/2839843002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java File chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java (right): https://codereview.chromium.org/2839843002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java#newcode766 chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java:766: formattedUrl = '\u200E' + formattedUrl; On 2017/04/27 01:36:33, tommycli ...
3 years, 8 months ago (2017-04-27 03:33:07 UTC) #15
Matt Giuca
lgtm, with one nit to move the Unicode character into a named constant.
3 years, 8 months ago (2017-04-27 03:33:26 UTC) #16
Ted C
drive by owners lgtm https://codereview.chromium.org/2839843002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java File chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java (right): https://codereview.chromium.org/2839843002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java#newcode766 chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java:766: formattedUrl = '\u200E' + formattedUrl; ...
3 years, 7 months ago (2017-04-27 16:26:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839843002/60001
3 years, 7 months ago (2017-04-27 17:22:05 UTC) #21
tommycli
https://codereview.chromium.org/2839843002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java File chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java (right): https://codereview.chromium.org/2839843002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java#newcode766 chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java:766: formattedUrl = '\u200E' + formattedUrl; On 2017/04/27 03:33:07, Matt ...
3 years, 7 months ago (2017-04-27 17:23:14 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 19:07:09 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e1fa8fc5972327ce78225c7de951...

Powered by Google App Engine
This is Rietveld 408576698