Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2839823002: Android: enable HW encoding (Closed)

Created:
3 years, 8 months ago by braveyao
Modified:
3 years, 8 months ago
Reviewers:
jam, jwd
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: enable HW encoding Android video encode accelerator was disabled based on gpu blacklist since the day it's born, as in https://codereview.chromium.org/74563002/#ps330001. We have tweaked the encoding codes on Android a bit. Now H264 has been enabled by default for WebRTC calls. And VP8&H264 are enabled for MediaRecorder too recently. Both are done by bypassing the blacklist. So it's time to enable HW encoding on Android. This CL is to revert the PS#3 of https://codereview.chromium.org/74563002, as removing the entry in gpu blacklist to enable HW encoing on Android. And add a flag to keep VP8 disabled for WebRTC for now. BUG=709118 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2839823002 Cr-Commit-Position: refs/heads/master@{#467050} Committed: https://chromium.googlesource.com/chromium/src/+/96c9b34ea924ed4300f90839cab36adf4f8eaecc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -44 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M content/public/browser/gpu_utils.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/config/software_rendering_list.json View 1 chunk +0 lines, -11 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
braveyao
Hi jam@, please take a look.
3 years, 8 months ago (2017-04-25 00:12:16 UTC) #12
jam
lgtm
3 years, 8 months ago (2017-04-25 16:42:40 UTC) #13
braveyao
Thanks jam@! + jwd@ for owner's review to tools/metrics/histograms/histograms.xml
3 years, 8 months ago (2017-04-25 17:19:12 UTC) #15
jwd
lgtm
3 years, 8 months ago (2017-04-25 18:12:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839823002/20001
3 years, 8 months ago (2017-04-25 18:19:17 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 18:23:37 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/96c9b34ea924ed4300f90839cab3...

Powered by Google App Engine
This is Rietveld 408576698