Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2839813005: PaymentHandler: Fix a typo (camelCase to hacker_case). (Closed)

Created:
3 years, 8 months ago by zino
Modified:
3 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, tzik, yzshen+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, gogerald+paymentswatch_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, rouslan+payments_chromium.org, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, mahmadi+paymentswatch_chromium.org, horo+watch_chromium.org, darin (slow to review), sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentHandler: Fix a typo (camelCase to hacker_case). This CL is initiated from: https://codereview.chromium.org/2844463002/diff/1/components/payments/mojom/payment_app.mojom#newcode51 BUG=661608 Review-Url: https://codereview.chromium.org/2839813005 Cr-Commit-Position: refs/heads/master@{#467357} Committed: https://chromium.googlesource.com/chromium/src/+/bc3eab186179c51acfb9a142252bf163ac53dbfd

Patch Set 1 #

Patch Set 2 : PaymentHandler: Fix a typo (camelCase to hacker_case). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/android/payments/service_worker_payment_app_bridge.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/payments/mojom/payment_app.mojom View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/payments/payment_app_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/payments/payment_app_provider_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_type_converters.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
zino
PTAL
3 years, 8 months ago (2017-04-25 21:56:57 UTC) #3
zino
nhiroki@ for serviceworker Tom Sepez@ for mojom rouslan@ for payments
3 years, 8 months ago (2017-04-25 21:58:05 UTC) #4
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-25 22:25:08 UTC) #5
Tom Sepez
RS LGTM
3 years, 8 months ago (2017-04-25 22:45:14 UTC) #6
nhiroki
lgtm
3 years, 8 months ago (2017-04-25 23:10:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839813005/1
3 years, 8 months ago (2017-04-26 14:42:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/165305)
3 years, 8 months ago (2017-04-26 15:07:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839813005/20001
3 years, 8 months ago (2017-04-26 16:49:42 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 17:12:49 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bc3eab186179c51acfb9a142252b...

Powered by Google App Engine
This is Rietveld 408576698