Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2839813004: Revert of Android: enable H264&VP8 HW accelerator for MediaRecorder (Closed)

Created:
3 years, 8 months ago by Max Morin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, emircan+watch+mediarecorder_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+mediarecorder_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: enable H264&VP8 HW accelerator for MediaRecorder (patchset #1 id:1 of https://codereview.chromium.org/2834233002/ ) Reason for revert: Speculative revert for test failures on Android, crbug.com/715071. Original issue's description: > Reland of Android: enable H264&VP8 HW accelerator for MediaRecorder (patchset #1 id:1 of https://codereview.chromium.org/2832263003/ ) > > Reason for revert: > Before this revert has landed, the bot went back to green, it's possible it's just a flake. gonna revert this revert for now > > https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/11452 > > Original issue's description: > > Revert of Android: enable H264&VP8 HW accelerator for MediaRecorder (patchset #12 id:400001 of https://codereview.chromium.org/2801803002/ ) > > > > Reason for revert: > > The CL seem to be responsible for this failure: https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/11451 > > > > Original issue's description: > > > Android: enable H264&VP8 HW accelerator for MediaRecorder > > > > > > The HW encoding codes has been revised a bit recently and works pretty well now. > > > This cl is to enable H264&VP8 HW accelerator for MediaRecorder on Android. > > > > > > BUG=638664 > > > > > > Review-Url: https://codereview.chromium.org/2801803002 > > > Cr-Commit-Position: refs/heads/master@{#466414} > > > Committed: https://chromium.googlesource.com/chromium/src/+/feabf3776925e38aab3e7f5eb20e90860cc49b71 > > > > TBR=dalecurtis@chromium.org,chcunningham@chromium.org,emircan@chromium.org,mcasas@chromium.org,braveyao@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=638664 > > > > Review-Url: https://codereview.chromium.org/2832263003 > > Cr-Commit-Position: refs/heads/master@{#466480} > > Committed: https://chromium.googlesource.com/chromium/src/+/36728e56fac466656a8504cbcbd573576b9c0bdb > > TBR=dalecurtis@chromium.org,chcunningham@chromium.org,emircan@chromium.org,mcasas@chromium.org,braveyao@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=638664 > > Review-Url: https://codereview.chromium.org/2834233002 > Cr-Commit-Position: refs/heads/master@{#466762} > Committed: https://chromium.googlesource.com/chromium/src/+/acb8a289bdc8dccf1e4bd726a29f10b15ed281f8 TBR=dalecurtis@chromium.org,chcunningham@chromium.org,emircan@chromium.org,mcasas@chromium.org,braveyao@chromium.org,yolandyan@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638664, 715071

Patch Set 1 #

Patch Set 2 : Revert "Reland of Android: enable H264&VP8 HW accelerator for MediaRecorder (patchset #1 id:1 of ht… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -29 lines) Patch
M content/browser/webrtc/webrtc_media_recorder_browsertest.cc View 1 3 chunks +1 line, -8 lines 0 comments Download
M content/renderer/media_recorder/media_recorder_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media_recorder/video_track_recorder.h View 1 3 chunks +1 line, -12 lines 0 comments Download
M content/renderer/media_recorder/video_track_recorder.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M content/renderer/media_recorder/video_track_recorder_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Max Morin
Created Revert of Android: enable H264&VP8 HW accelerator for MediaRecorder
3 years, 8 months ago (2017-04-25 12:07:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839813004/1
3 years, 8 months ago (2017-04-25 12:07:36 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 12:07:58 UTC) #6
Failed to apply patch for content/test/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: content/test/BUILD.gn:931
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: content/test/BUILD.gn: patch does not apply

Patch:       content/test/BUILD.gn
Index: content/test/BUILD.gn
diff --git a/content/test/BUILD.gn b/content/test/BUILD.gn
index
744f0a22e79123d32b2db99d1e779456f40faf2e..2c30533198316a366bdaa9c0485bb9fe5b6ee4e3
100644
--- a/content/test/BUILD.gn
+++ b/content/test/BUILD.gn
@@ -931,10 +931,7 @@
       "../browser/webrtc/webrtc_webcam_browsertest.cc",
       "../browser/webrtc/webrtc_webcam_browsertest.h",
     ]
-    deps += [
-      "//testing/perf",
-      "//content/public/common:features",
-    ]
+    deps += [ "//testing/perf" ]
   }
 
   if (enable_plugins) {

Powered by Google App Engine
This is Rietveld 408576698