Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2834233002: Reland of Android: enable H264&VP8 HW accelerator for MediaRecorder (Closed)

Created:
3 years, 8 months ago by Yoland Yan(Google)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, emircan+watch+mediarecorder_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+mediarecorder_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Android: enable H264&VP8 HW accelerator for MediaRecorder (patchset #1 id:1 of https://codereview.chromium.org/2832263003/ ) Reason for revert: Before this revert has landed, the bot went back to green, it's possible it's just a flake. gonna revert this revert for now https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/11452 Original issue's description: > Revert of Android: enable H264&VP8 HW accelerator for MediaRecorder (patchset #12 id:400001 of https://codereview.chromium.org/2801803002/ ) > > Reason for revert: > The CL seem to be responsible for this failure: https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/11451 > > Original issue's description: > > Android: enable H264&VP8 HW accelerator for MediaRecorder > > > > The HW encoding codes has been revised a bit recently and works pretty well now. > > This cl is to enable H264&VP8 HW accelerator for MediaRecorder on Android. > > > > BUG=638664 > > > > Review-Url: https://codereview.chromium.org/2801803002 > > Cr-Commit-Position: refs/heads/master@{#466414} > > Committed: https://chromium.googlesource.com/chromium/src/+/feabf3776925e38aab3e7f5eb20e90860cc49b71 > > TBR=dalecurtis@chromium.org,chcunningham@chromium.org,emircan@chromium.org,mcasas@chromium.org,braveyao@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=638664 > > Review-Url: https://codereview.chromium.org/2832263003 > Cr-Commit-Position: refs/heads/master@{#466480} > Committed: https://chromium.googlesource.com/chromium/src/+/36728e56fac466656a8504cbcbd573576b9c0bdb TBR=dalecurtis@chromium.org,chcunningham@chromium.org,emircan@chromium.org,mcasas@chromium.org,braveyao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638664 Review-Url: https://codereview.chromium.org/2834233002 Cr-Commit-Position: refs/heads/master@{#466762} Committed: https://chromium.googlesource.com/chromium/src/+/acb8a289bdc8dccf1e4bd726a29f10b15ed281f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -11 lines) Patch
M content/browser/webrtc/webrtc_media_recorder_browsertest.cc View 3 chunks +8 lines, -1 line 0 comments Download
M content/renderer/media_recorder/media_recorder_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media_recorder/video_track_recorder.h View 3 chunks +12 lines, -1 line 0 comments Download
M content/renderer/media_recorder/video_track_recorder.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/renderer/media_recorder/video_track_recorder_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Yoland Yan(Google)
Created Reland of Android: enable H264&VP8 HW accelerator for MediaRecorder
3 years, 8 months ago (2017-04-21 23:43:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834233002/1
3 years, 8 months ago (2017-04-21 23:43:39 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-21 23:43:40 UTC) #5
emircan
lgtm
3 years, 8 months ago (2017-04-22 00:01:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834233002/1
3 years, 8 months ago (2017-04-24 21:06:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/acb8a289bdc8dccf1e4bd726a29f10b15ed281f8
3 years, 8 months ago (2017-04-24 21:07:04 UTC) #11
perezju
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2844453003/ by perezju@chromium.org. ...
3 years, 8 months ago (2017-04-25 12:07:02 UTC) #12
Max Morin
3 years, 8 months ago (2017-04-25 12:07:24 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2839813004/ by maxmorin@chromium.org.

The reason for reverting is: Speculative revert for test failures on Android,
crbug.com/715071..

Powered by Google App Engine
This is Rietveld 408576698