Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2839813002: Only autohide the cursor when we are on a text entry field. (Closed)

Created:
3 years, 8 months ago by dtapuska
Modified:
3 years, 7 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only autohide the cursor when we are on a text entry field. Previously we autohid the cursor whenever a keydown occurred. But this presents issues for pages that don't want the cursor auto hidden but still receive key events. Instead we are going to autohide the cursor when there is a text input type set; which means the focus is inside a text input entry field. The cursor will no longer autohide if you are scrolling via the arrow keys but this seems like a reasonable tradeoff. BUG=713202 Review-Url: https://codereview.chromium.org/2839813002 Cr-Commit-Position: refs/heads/master@{#467012} Committed: https://chromium.googlesource.com/chromium/src/+/32e2eec87fcd9c791791f4e67c76a85eab7f9ed8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dtapuska
Let me know what you think.
3 years, 8 months ago (2017-04-24 20:47:21 UTC) #3
erikchen
lgtm
3 years, 8 months ago (2017-04-24 20:57:10 UTC) #4
dtapuska
asvitkine@chromium.org: Please review changes in for owner review.
3 years, 8 months ago (2017-04-24 21:10:30 UTC) #6
Alexei Svitkine (slow)
rs lgtm, deferring to erikchen for the actual review
3 years, 7 months ago (2017-04-25 15:46:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839813002/1
3 years, 7 months ago (2017-04-25 15:54:37 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 16:35:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32e2eec87fcd9c791791f4e67c76...

Powered by Google App Engine
This is Rietveld 408576698