Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2839753007:
Android: Remove unused clipboard unittests (Closed)
DescriptionAndroid: Remove unused clipboard unittests
clipboard_android_unittests.cc was included in
//chrome/test:interactive_ui_tests but that test is not run on android
(see !is_android gn flag). Removing it since it has not been ported
over to jni.
This is directly blocking the removal of GetApplicatContext. Any attempt
to get the test back should rewrite it on java side with jni.
BUG=434620
Review-Url: https://codereview.chromium.org/2839753007
Cr-Commit-Position: refs/heads/master@{#467648}
Committed: https://chromium.googlesource.com/chromium/src/+/5ee5e9de1ad33b5a70560394753c960187fe5ce3
Patch Set 1 #
Messages
Total messages: 26 (15 generated)
wnwen@chromium.org changed reviewers: + tobiasjs@chromium.org
Hi Toby, I am working on the removal of base/android/context_utils.* and the last use without jni is in this unused unit test. Please take a look as this is directly blocking finishing up that refactoring project. It's been almost 2 years since http://crbug.com/434620 has been updated. Thank you, Peter
On 2017/04/26 15:40:15, Peter Wen wrote: > Hi Toby, > > I am working on the removal of base/android/context_utils.* and the last use > without jni is in this unused unit test. Please take a look as this is directly > blocking finishing up that refactoring project. It's been almost 2 years since > http://crbug.com/434620 has been updated. > > Thank you, > > Peter LGTM to removing this - especially as - as you say - it's not run. There probably should be a bug created for reimplementing the tests.
The CQ bit was checked by wnwen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/26 16:09:28, Tobias Sargeant wrote: > On 2017/04/26 15:40:15, Peter Wen wrote: > > Hi Toby, > > > > I am working on the removal of base/android/context_utils.* and the last use > > without jni is in this unused unit test. Please take a look as this is > directly > > blocking finishing up that refactoring project. It's been almost 2 years since > > http://crbug.com/434620 has been updated. > > > > Thank you, > > > > Peter > > LGTM to removing this - especially as - as you say - it's not run. There > probably should be a bug created for reimplementing the tests. Thanks for the review! Filed http://crbug.com/715619.
wnwen@chromium.org changed reviewers: + ccameron@chromium.org
+ccameron@ for ui/base/clipboard/clipboard_android_unittests.cc OWNERS as dcheng@ is out.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
wnwen@chromium.org changed reviewers: - tobiasjs@chromium.org
-ccameron as he is also OOO
Description was changed from ========== Android: Remove unused clipboard unittests clipboard_android_unittests.cc was included in //chrome/test:interactive_ui_tests but that test is not run on android (see !is_android gn flag). Removing it since it has not been ported over to jni. This is directly blocking the removal of GetApplicatContext. Any attempt to get the test back should rewrite it on java side with jni. BUG=434620 ========== to ========== Android: Remove unused clipboard unittests clipboard_android_unittests.cc was included in //chrome/test:interactive_ui_tests but that test is not run on android (see !is_android gn flag). Removing it since it has not been ported over to jni. This is directly blocking the removal of GetApplicatContext. Any attempt to get the test back should rewrite it on java side with jni. BUG=434620 ==========
wnwen@chromium.org changed reviewers: + tobiasjs@chromium.org - ccameron@chromium.org
wnwen@chromium.org changed reviewers: + sadrul@chromium.org
+sadrul@ for ui/base/clipboard/clipboard_android_unittests.cc OWNERS. This test is not currently run anywhere.
The CQ bit was checked by wnwen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by wnwen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493295945437010, "parent_rev":
"3c11446af335799e978030292e28c1a2094df608", "commit_rev":
"5ee5e9de1ad33b5a70560394753c960187fe5ce3"}
Message was sent while issue was closed.
Description was changed from ========== Android: Remove unused clipboard unittests clipboard_android_unittests.cc was included in //chrome/test:interactive_ui_tests but that test is not run on android (see !is_android gn flag). Removing it since it has not been ported over to jni. This is directly blocking the removal of GetApplicatContext. Any attempt to get the test back should rewrite it on java side with jni. BUG=434620 ========== to ========== Android: Remove unused clipboard unittests clipboard_android_unittests.cc was included in //chrome/test:interactive_ui_tests but that test is not run on android (see !is_android gn flag). Removing it since it has not been ported over to jni. This is directly blocking the removal of GetApplicatContext. Any attempt to get the test back should rewrite it on java side with jni. BUG=434620 Review-Url: https://codereview.chromium.org/2839753007 Cr-Commit-Position: refs/heads/master@{#467648} Committed: https://chromium.googlesource.com/chromium/src/+/5ee5e9de1ad33b5a70560394753c... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5ee5e9de1ad33b5a70560394753c... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
