Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/values.cc

Issue 2839753005: Remove base::Value::GetAsBinary (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/values.h ('k') | base/values_unittest.cc » ('j') | chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.cc
diff --git a/base/values.cc b/base/values.cc
index ab0150cba5ff0a81688d54ba8ce6dc534ea41cdd..3397f1c3450c21c5cd58937c36ce9786cc41fb12 100644
--- a/base/values.cc
+++ b/base/values.cc
@@ -304,14 +304,6 @@ bool Value::GetAsString(StringPiece* out_value) const {
return is_string();
}
-bool Value::GetAsBinary(const Value** out_value) const {
- if (out_value && is_blob()) {
- *out_value = this;
- return true;
- }
- return is_blob();
-}
-
bool Value::GetAsList(ListValue** out_value) {
if (out_value && is_list()) {
*out_value = static_cast<ListValue*>(this);
« no previous file with comments | « base/values.h ('k') | base/values_unittest.cc » ('j') | chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698