Remove base::Value::GetAsBinary

chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

Index: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
diff --git a/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc b/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
index 0a16e496606469b6584851e84c71553d0dadaf12..8b919cbce5456a86ff1851b4863fd4fa610d52ec 100644
--- a/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
+++ b/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
@@ -72,11 +72,9 @@ void StoreString(std::string* result,
 void StoreDigest(std::vector<uint8_t>* digest,
                  const base::Closure& callback,
                  const base::Value* value) {
-  const base::Value* binary = nullptr;
-  const bool is_binary = value->GetAsBinary(&binary);
-  EXPECT_TRUE(is_binary) << "Unexpected value in StoreDigest";
-  if (is_binary) {
-    digest->assign(binary->GetBlob().begin(), binary->GetBlob().end());
+  EXPECT_TRUE(value->is_blob()) << "Unexpected value in StoreDigest";
+  if (value->is_blob()) {

[jdoerrie, 2017/04/25 12:49:16]

Due to the EXPECT_TRUE above this code should never be reached if the value is
not a blob. Thus this if-clause can be removed, correct?

[Robert Sesek, 2017/04/25 14:06:42]

ASSERT_TRUE would be better, since it will interrupt the control flow.

[jdoerrie, 2017/04/25 14:14:33]

Done.

+    digest->assign(value->GetBlob().begin(), value->GetBlob().end());
   }
 
   callback.Run();