Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2839753003: Use TaskScheduler instead of blocking pool in webapk_installer.cc. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
Reviewers:
dominickn
CC:
chromium-reviews, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of blocking pool in webapk_installer.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=dominickn@chromium.org Review-Url: https://codereview.chromium.org/2839753003 Cr-Commit-Position: refs/heads/master@{#467234} Committed: https://chromium.googlesource.com/chromium/src/+/4cf46bceeded936616cb03d8a384e0b4005c400d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/android/webapk/webapk_installer.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
fdoray
3 years, 8 months ago (2017-04-24 19:24:09 UTC) #1
fdoray
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used ...
3 years, 8 months ago (2017-04-24 19:24:11 UTC) #3
dominickn
lgtm, thanks
3 years, 8 months ago (2017-04-26 01:02:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839753003/1
3 years, 8 months ago (2017-04-26 02:56:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/256625)
3 years, 8 months ago (2017-04-26 03:20:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839753003/1
3 years, 8 months ago (2017-04-26 04:14:05 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 04:38:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4cf46bceeded936616cb03d8a384...

Powered by Google App Engine
This is Rietveld 408576698